Skip to content

Cast srcset to string before trimming explode#111

Open
EmanuelOster wants to merge 1 commit intositegeist:masterfrom
EmanuelOster:master
Open

Cast srcset to string before trimming explode#111
EmanuelOster wants to merge 1 commit intositegeist:masterfrom
EmanuelOster:master

Conversation

@EmanuelOster
Copy link
Copy Markdown

When using the following example, Fluid interprets the srcset as int, which breaks the trimExplode function.

<sms:image
    image="{image.0}"
    breakpoints="{
    0: {
          'cropVariant': 'some_variant',
          'media': '(min-resolution: 2x)',
          'srcset': '600',
          'sizes': '300px, 100vw',
          },
[...]

This PR resolves this by casting the value to string before handing it over to the function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant