Skip to content

Conversation

@stefan-laux
Copy link
Collaborator

Due to a error in the documentation where you couldnt see the picto i reverted all the changes.

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@colinscz colinscz self-requested a review February 26, 2025 15:46
@ibirrer ibirrer self-requested a review March 3, 2025 11:39
Copy link
Collaborator

@ibirrer ibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits and rebase it on main.

moved svgs from scss file to assets (should improve chunk size) currently picto-entry.js is 500kb big.

fix tests

rollback to old status
@stefan-laux stefan-laux force-pushed the feature/picto-move-svgs-to-assets branch from 4ffd20a to 6d8b0d7 Compare May 16, 2025 14:21
@colinscz colinscz requested a review from ibirrer May 19, 2025 11:40
@colinscz colinscz merged commit 93c8f70 into main May 19, 2025
1 check passed
@colinscz colinscz deleted the feature/picto-move-svgs-to-assets branch May 19, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants