Skip to content

feat: improve six-sidebar component #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Conversation

JoelLeupp
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Add support for icons in six-sidbar-item
  • fix spacing for six-sidbar sub-items
  • added sidbar helper directives for angular: ActiveSidebarItemGroupDirective and ActiveSidebarItemDirective
  • added a nested sidbar menu in the angular demo app to showcase the helper directives

πŸ“ Checklist

  • It's submitted to the main branch
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

@JoelLeupp JoelLeupp force-pushed the feature/six-sidebar-improvement branch from 19c0c92 to db6af71 Compare April 17, 2025 11:42
@JoelLeupp JoelLeupp requested review from ibirrer and huecking and removed request for ibirrer April 17, 2025 11:46
@JoelLeupp JoelLeupp self-assigned this Apr 17, 2025
@JoelLeupp JoelLeupp requested review from ibirrer and colinscz April 17, 2025 11:46
@JoelLeupp JoelLeupp requested a review from ibirrer April 24, 2025 09:48
@JoelLeupp JoelLeupp changed the title feat: add icon support for six-sidbar-item feat: improve six-sidebar component Apr 24, 2025
@JoelLeupp JoelLeupp force-pushed the feature/six-sidebar-improvement branch from aa97b59 to d3f6547 Compare April 24, 2025 11:35
@JoelLeupp JoelLeupp force-pushed the feature/six-sidebar-improvement branch from d3f6547 to ce16484 Compare April 24, 2025 12:53
@JoelLeupp JoelLeupp force-pushed the feature/six-sidebar-improvement branch from ce16484 to e43c733 Compare April 24, 2025 13:04
@JoelLeupp JoelLeupp requested a review from ibirrer April 24, 2025 13:10
@JoelLeupp JoelLeupp merged commit bd0dde8 into main Apr 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants