Support SIYUAN_WORKSPACE_PATH in Docker#14256
Closed
luke-zhu wants to merge 1 commit intosiyuan-note:devfrom
Closed
Support SIYUAN_WORKSPACE_PATH in Docker#14256luke-zhu wants to merge 1 commit intosiyuan-note:devfrom
luke-zhu wants to merge 1 commit intosiyuan-note:devfrom
Conversation
|
Your PR was set to target |
The current entrypoint fails if the user uses --workspace /my/workspace with a space instead of an equals. This change supports that format as well as the SIYUAN_WORKSPACE_PATH env variable. SIYUAN_WORKSPACE_PATH=/should/be/ignored ./stuff.sh --workspace /my/workspace --workspace-prefix --fla g-equal=3 --flag-no-equal 4 WORKSPACE_DIR: /my/workspace ARGS: --workspace-prefix --flag-equal=3 --flag-no-equal 4 SIYUAN_WORKSPACE_PATH=/my/workspace ./stuff.sh --w orkspace-prefix --flag-equal=3 --flag-no-equal 4 WORKSPACE_DIR: /siyuan/workspace ARGS: --workspace-prefix --flag-equal=3 --flag-no-equal 4
c533b45 to
5e651ba
Compare
3 tasks
Member
|
Hi, to maintain consistency with other parameters (using |
Contributor
Author
|
Ok, well you still have the problem if the user uses SIYUAN_WORKSPACE_PATH |
Member
|
What you said makes sense. Can we just change SIYUAN_WORKSPACE_PATH support without changing |
Contributor
Author
|
Sure, I have updated the commit and the PR title |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current entrypoint fails if the user uses
--workspace /my/workspace with a space instead
of an equals.
This change supports that format as well as the
SIYUAN_WORKSPACE_PATH env variable.
Feature or bug? 特性或者缺陷?
Bug fix
Multilingual or copywriting? 多语言或者文案?
Please submit directly, we will evaluate.
请直接提交,我们会进行评估。
Dev branch!