Skip to content

Improve database asset field image browsing#14843

Merged
Vanessa219 merged 1 commit intosiyuan-note:devfrom
Jiangshuon:dev
May 18, 2025
Merged

Improve database asset field image browsing#14843
Vanessa219 merged 1 commit intosiyuan-note:devfrom
Jiangshuon:dev

Conversation

@Jiangshuon
Copy link
Copy Markdown
Contributor

@Jiangshuon Jiangshuon commented May 16, 2025

fix #11900

@Jiangshuon
Copy link
Copy Markdown
Contributor Author

Jiangshuon commented May 17, 2025

@88250 D大快瞅一眼!这个功能期待很久了,想尽快能用上!但一直没动静,所以就自己搞了。代码很简单(照着原来的函数ctrl cv了一下),测试了没问题

@Vanessa219 Vanessa219 requested review from 88250 and Vanessa219 May 18, 2025 03:13
@Vanessa219 Vanessa219 merged commit 2b03a36 into siyuan-note:dev May 18, 2025
2 checks passed
@Vanessa219 Vanessa219 added this to the 3.1.30 milestone May 18, 2025
88250 added a commit that referenced this pull request May 18, 2025
Vanessa219 added a commit that referenced this pull request May 18, 2025
@Jiangshuon
Copy link
Copy Markdown
Contributor Author

@Vanessa219 v大,感觉保留query好一些吧,这样可以只看搜索出来的条目的图片

@TCOTC
Copy link
Copy Markdown
Contributor

TCOTC commented May 18, 2025

可以只看搜索出来的条目的图片

我认为这个需求合理

@Vanessa219
Copy link
Copy Markdown
Member

过滤条件不全,只用 query 的话会有分歧。比如排序,列上的过滤条件等。

@Jiangshuon
Copy link
Copy Markdown
Contributor Author

api返回的数据已经是把列筛选过滤了的

@Jiangshuon
Copy link
Copy Markdown
Contributor Author

query参数传的只是搜索框的内容。列筛选排序相关的是根据当前视图id(viewid)确定的,不传query参数的话,浏览的比实际展现的要多了

@88250 88250 changed the title Optimize attributeView image browsing Improve database asset field image browsing May 19, 2025
@88250 88250 removed this from the 3.1.30 milestone May 19, 2025
@Vanessa219
Copy link
Copy Markdown
Member

那 pageSize 啥的呢?这个也移除了。

@Jiangshuon
Copy link
Copy Markdown
Contributor Author

pageSize应该没必要加了,我看D大把api关于pageSize的也删掉了

Vanessa219 added a commit that referenced this pull request May 20, 2025
EightDoor added a commit to EightDoor/siyuan that referenced this pull request May 22, 2025
* commit 'b3764d6a20dce9dde1ae1fcfc2dd11c2d60df2f3': (35 commits)
  🎨 siyuan-note#14843
  🔖 Release v3.1.30
  🔖 Release v3.1.30
  📝 Update changelogs
  ♻️ siyuan-note#14851
  🐛 Improve resizing image width by dragging (siyuan-note#14851)
  📝 Update changelogs
  🎨 siyuan-note#14821
  🎨 siyuan-note#14843
  🎨 Improve av image preview siyuan-note#14843
  Optimize attributeView image browsing (siyuan-note#14843)
  🎨 Improve the style of folded lists (siyuan-note#14830)
  🎨 siyuan-note#14813
  🎨 Improve exporting to YueQue siyuan-note#14846
  📝 Update the user guide
  🎨 siyuan-note#14821
  🎨 siyuan-note#14324
  🐛 Fix cron job setup siyuan-note#14817
  ⬆️ Upgrade kernel deps
  🎨 Improve exporting image
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants