Skip to content

Add data-close-counter attribute #14962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TCOTC wants to merge 1 commit into from
Closed

Add data-close-counter attribute #14962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions app/src/layout/dock/Files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,7 @@ data-type="navigation-root" data-path="/">
this.closeElement.lastElementChild.innerHTML = closeHtml;
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = closeCounter.toString();
this.closeElement.dataset.closeCounter = closeCounter.toString();
if (closeCounter) {
counterElement.classList.remove("fn__none");
} else {
Expand Down Expand Up @@ -898,7 +899,9 @@ data-type="navigation-root" data-path="/">
});
this.closeElement.lastElementChild.innerHTML = closeHTML;
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = (parseInt(counterElement.textContent) + 1).toString();
const closeCounter = (parseInt(counterElement.textContent) + 1).toString();
counterElement.textContent = closeCounter;
this.closeElement.dataset.closeCounter = closeCounter;
counterElement.classList.remove("fn__none");
}
}
Expand All @@ -908,8 +911,10 @@ data-type="navigation-root" data-path="/">
if (removeElement) {
removeElement.remove();
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = (parseInt(counterElement.textContent) - 1).toString();
if (counterElement.textContent === "0") {
const closeCounter = (parseInt(counterElement.textContent) - 1).toString();
counterElement.textContent = closeCounter;
this.closeElement.dataset.closeCounter = closeCounter;
if (closeCounter === "0") {
counterElement.classList.add("fn__none");
}
}
Expand Down Expand Up @@ -952,8 +957,10 @@ data-type="navigation-root" data-path="/">
const liElement = this.closeElement.querySelector(`li[data-url="${data.data.box.id}"]`) as HTMLElement;
if (liElement) {
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = (parseInt(counterElement.textContent) - 1).toString();
if (counterElement.textContent === "0") {
const closeCounter = (parseInt(counterElement.textContent) - 1).toString();
counterElement.textContent = closeCounter;
this.closeElement.dataset.closeCounter = closeCounter;
if (closeCounter === "0") {
counterElement.classList.add("fn__none");
}
liElement.remove();
Expand Down
17 changes: 12 additions & 5 deletions app/src/mobile/dock/MobileFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ export class MobileFiles extends Model {
this.closeElement.lastElementChild.innerHTML = closeHtml;
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = closeCounter.toString();
this.closeElement.dataset.closeCounter = closeCounter.toString();
if (closeCounter) {
counterElement.classList.remove("fn__none");
} else {
Expand Down Expand Up @@ -436,7 +437,9 @@ export class MobileFiles extends Model {
});
this.closeElement.lastElementChild.innerHTML = closeHTML;
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = (parseInt(counterElement.textContent) + 1).toString();
const closeCounter = (parseInt(counterElement.textContent) + 1).toString();
counterElement.textContent = closeCounter;
this.closeElement.dataset.closeCounter = closeCounter;
counterElement.classList.remove("fn__none");
}
}
Expand All @@ -446,8 +449,10 @@ export class MobileFiles extends Model {
if (removeElement) {
removeElement.remove();
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = (parseInt(counterElement.textContent) - 1).toString();
if (counterElement.textContent === "0") {
const closeCounter = (parseInt(counterElement.textContent) - 1).toString();
counterElement.textContent = closeCounter;
this.closeElement.dataset.closeCounter = closeCounter;
if (closeCounter === "0") {
counterElement.classList.add("fn__none");
}
}
Expand Down Expand Up @@ -500,8 +505,10 @@ export class MobileFiles extends Model {
if (liElement) {
liElement.remove();
const counterElement = this.closeElement.querySelector(".counter");
counterElement.textContent = (parseInt(counterElement.textContent) - 1).toString();
if (counterElement.textContent === "0") {
const closeCounter = (parseInt(counterElement.textContent) - 1).toString();
counterElement.textContent = closeCounter;
this.closeElement.dataset.closeCounter = closeCounter;
if (closeCounter === "0") {
counterElement.classList.add("fn__none");
}
}
Expand Down