Skip to content

Add a 'Remember me' checkbox when logging in to save a session#14964

Merged
88250 merged 1 commit intosiyuan-note:devfrom
tomershvueli:tomer/remember-me-session
Jun 4, 2025
Merged

Add a 'Remember me' checkbox when logging in to save a session#14964
88250 merged 1 commit intosiyuan-note:devfrom
tomershvueli:tomer/remember-me-session

Conversation

@tomershvueli
Copy link
Copy Markdown
Contributor

…for 30 days

Feature or bug? 特性或者缺陷?

Feature. This has been discussed in #12219.

Multilingual or copywriting? 多语言或者文案?

Please submit directly, we will evaluate.
请直接提交,我们会进行评估。

Dev branch!

Any changes should be submitted to the dev branch.
任何改动,请提交到 dev 分支。

This codebase and Go are new to me, so happy to get any notes around this implementation and open to other ideas of how to go about this. For example, I noticed that MaxAge has been commented out here, not sure the history behind that, but setting a value there might get us what we need as well.

Thanks for all your hard work on this project!

@88250 88250 added this to the 3.1.33 milestone Jun 4, 2025
@88250 88250 changed the title feat: Add a 'remember me' checkbox when logging in to save a session … Add a 'remember me' checkbox when logging in to save a session Jun 4, 2025
@88250 88250 merged commit aa35dd8 into siyuan-note:dev Jun 4, 2025
2 checks passed
@88250
Copy link
Copy Markdown
Member

88250 commented Jun 4, 2025

Thank you for your contribution. SiYuan will be more wonderful with you!

@88250 88250 changed the title Add a 'remember me' checkbox when logging in to save a session Add a 'Remember me' checkbox when logging in to save a session Jun 4, 2025
@tomershvueli tomershvueli deleted the tomer/remember-me-session branch June 4, 2025 21:48
@88250 88250 modified the milestones: 3.1.33, 3.2.0 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants