Skip to content

Support HTTPS network serving - #16930

Merged
88250 merged 6 commits into
siyuan-note:devfrom
DD3Boh:feat/https-network-serving-v2
Jan 29, 2026
Merged

Support HTTPS network serving#16930
88250 merged 6 commits into
siyuan-note:devfrom
DD3Boh:feat/https-network-serving-v2

Conversation

@DD3Boh

@DD3Boh DD3Boh commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Implement HTTPS support for network serving, with self signed certificates that can be imported and exported. This feature has been talked about in issue #16887 and #16912 before submitting the PR.

The implementation allows accessing the network serving on the fixed 6806 port in both HTTP and HTTPS mode, filtering according to the first bytes of the input that the server receives.

@DD3Boh

DD3Boh commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

This time around the fixed port supports both http and https. I didn't implement the same thing for the dynamic port, since I think this is a more complicated handling compared to straight http or https (since it leverages cmux and filtering). For that reason, I only wanted to add it where I think it's actually needed and useful, which is the fixed port.
But let me know if you think it should also go on the dynamic port.

@88250
88250 self-requested a review January 28, 2026 09:11
@88250 88250 added this to the 3.5.5 milestone Jan 28, 2026
@88250 88250 changed the title Implement HTTPS network serving Support HTTPS for network serving Jan 28, 2026
@88250 88250 changed the title Support HTTPS for network serving Support HTTPS network serving Jan 28, 2026
@88250

88250 commented Jan 29, 2026

Copy link
Copy Markdown
Member

Okay, we will only implement HTTPS on port 6806; dynamic port support will not be implemented for now. Thank you.

@88250
88250 merged commit cff1261 into siyuan-note:dev Jan 29, 2026
4 checks passed
@88250

88250 commented Jan 29, 2026

Copy link
Copy Markdown
Member

感谢你的贡献,思源有你更精彩!
Thank you for your contribution. SiYuan will be more wonderful with you!

@88250

88250 commented Jan 29, 2026

Copy link
Copy Markdown
Member

Several adjustments were made:

88250 added a commit that referenced this pull request Jan 29, 2026
Signed-off-by: Daniel <845765@qq.com>
88250 added a commit that referenced this pull request Jan 29, 2026
Signed-off-by: Daniel <845765@qq.com>
@TCOTC

TCOTC commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

“启用 HTTPS”、“导出 CA 证书”、“导出 CA 证书包”、“导入 CA 证书包”应该是“网络伺服”的子项,在开启“网络伺服”之后才显示

@88250

88250 commented Jan 29, 2026

Copy link
Copy Markdown
Member

@Vanessa219

88250 added a commit that referenced this pull request Jan 29, 2026
Signed-off-by: Daniel <845765@qq.com>
88250 added a commit that referenced this pull request Jan 29, 2026
Signed-off-by: Daniel <845765@qq.com>
@Vanessa219 Vanessa219 self-assigned this Jan 29, 2026
Vanessa219 added a commit that referenced this pull request Jan 29, 2026
@TCOTC

TCOTC commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

@Vanessa219 关闭网络伺服的时候会隐藏下面的子项,但重启之后子项又直接显示出来了:

PixPin_2026-02-01_13-43-59

Vanessa219 added a commit that referenced this pull request Feb 1, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants