Ensure that the isBatchClose = true parameter is included when executing removeTab within the closeTabByType function - #16954
Closed
TCOTC wants to merge 1 commit into
Closed
Ensure that the isBatchClose = true parameter is included when executing removeTab within the closeTabByType function#16954TCOTC wants to merge 1 commit into
isBatchClose = true parameter is included when executing removeTab within the closeTabByType function#16954TCOTC wants to merge 1 commit into
Conversation
TCOTC
commented
Jan 31, 2026
TCOTC
commented
Contributor
- 确保在 closeTabByType 函数里执行 removeTab 时带上 isBatchClose = true 参数。Fix Improve recent documents handling #16727 (comment)
- 确保收集到的 rootIDs 是有效数据。Fix Improve recent documents handling #16727 (comment)
…xecuting `removeTab` within the `closeTabByType` function
Member
|
这个点之前说过不进行修改了，以免出现问题。 目前求稳，正常运行的代码就进了不要去修改和重构，否则很容易出现问题。 |
Contributor
Author
|
但是目前的逻辑有缺陷啊 |
Member
|
前面讨论了，这个问题可以接受。 |
Contributor
Author
|
既然有办法解决，为什么不解决呢 |
Member
|
这个问题不大 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.