Skip to content

Only validate the name when the S3 bucket name changes#17433

Merged
88250 merged 1 commit intosiyuan-note:devfrom
TCOTC:fix/S3-bucket-name
Apr 9, 2026
Merged

Only validate the name when the S3 bucket name changes#17433
88250 merged 1 commit intosiyuan-note:devfrom
TCOTC:fix/S3-bucket-name

Conversation

@TCOTC
Copy link
Copy Markdown
Contributor

@TCOTC TCOTC commented Apr 8, 2026

Description / 描述

  • 仅在 S3 桶名变更时校验名称,避免桶名未填写时回写其他配置、避免初次配置时反复弹出错误提示 https://ld246.com/article/1775665943744
  • 导入云端配置时不再验证桶名,避免特殊情况下桶名为空导致配置无法被导入

Type of change / 变更类型

  • Bug fix
    缺陷修复
  • Refactoring
    代码重构
  • New feature
    新功能
  • Text updates or new language additions
    修改文案或增加新语言

Checklist / 检查清单

  • I have performed a self-review of my own code
    我对自己的代码进行了自我审查
  • I have full rights to the submitted code and agree to license it under this project's AGPL-3.0 license
    我拥有所提交代码的完整权利,并同意其以本项目的 AGPL-3.0 许可证授权
  • PR is submitted to the dev branch and has no merge conflicts
    PR 提交到 dev 分支,并且没有合并冲突

@88250 88250 merged commit 68dde82 into siyuan-note:dev Apr 9, 2026
1 check passed
@88250
Copy link
Copy Markdown
Member

88250 commented Apr 9, 2026

v3.6.4

@TCOTC TCOTC deleted the fix/S3-bucket-name branch April 9, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants