Guard IME composition in the agent session rename input - #17988
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents IME composition-confirming key events from prematurely committing an agent session rename. It aligns the rename input’s key handling with the existing composition-guard behavior already used by the search input in the same panel.
Changes:
- Add an early return in the rename input
keydownhandler whenKeyboardEvent.isComposingis true. - Ensure Enter/Escape commit/revert behavior does not trigger during active IME composition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
感谢你的贡献，思源有你更精彩！ |
88250
pushed a commit
that referenced
this pull request
Jul 4, 2026
Co-authored-by: greymoth <246701683+greymoth-jp@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you rename a session in the agent dock, the rename input commits on Enter and reverts on Escape. Its keydown handler does not check
event.isComposing, so a composition-confirming Enter from an IME can reach the handler and blur the input, committing the rename with a half-composed title.The search input in this same component already returns early on
event.isComposingin its keydown handler. This change applies the same guard to the rename input so both inputs handle composition the same way. The check is a no-op when no IME is active.