Skip to content

Safely call kernel.destroy - #18085

Merged
Vanessa219 merged 1 commit into
siyuan-note:devfrom
TCOTC:fix/kernel.destroy
Jul 5, 2026
Merged

Safely call kernel.destroy#18085
Vanessa219 merged 1 commit into
siyuan-note:devfrom
TCOTC:fix/kernel.destroy

Conversation

@TCOTC

@TCOTC TCOTC commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Description / 描述

使用浅吟主题时,关闭新窗口时产生异常,没有捕获异常导致新窗口无法关闭:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'destroy')
    at closeWindow (closeWin.ts:13:29)
PixPin_2026-07-05_00-47-38

Type of change / 变更类型

  • Bug fix
    缺陷修复
  • Refactoring
    代码重构
  • New feature
    新功能
  • Text updates or new language additions
    修改文案或增加新语言

Checklist / 检查清单

  • I have performed a self-review of my own code
    我对自己的代码进行了自我审查
  • I have full rights to the submitted code and agree to license it under this project's AGPL-3.0 license
    我拥有所提交代码的完整权利,并同意其以本项目的 AGPL-3.0 许可证授权
  • PR is submitted to the dev branch and has no merge conflicts
    PR 提交到 dev 分支,并且没有合并冲突

@Vanessa219
Vanessa219 merged commit 669f02e into siyuan-note:dev Jul 5, 2026
1 check passed
@Vanessa219
Vanessa219 self-requested a review July 5, 2026 02:26
@Vanessa219 Vanessa219 added this to the 3.7.2 milestone Jul 5, 2026
Vanessa219 added a commit that referenced this pull request Jul 5, 2026
@TCOTC
TCOTC deleted the fix/kernel.destroy branch July 5, 2026 02:27
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants