Skip to content

Requests to not-existing urls return 400 #3

Description

@Sgoettschkes

We are using flask-csrf for our Rest API which serves a single-page-application. This means almost all our routes are csrf-protected and the few which are not are handled using csrf_exempt.

We recently found that a non-existing route triggers an (incorrect) 400 response code instead of the expected 404 and were able to trace this issue back to the csrf handling. The problem lies in https://github.com/sjl/flask-csrf/blob/master/flaskext/csrf.py#L31

Is there any specific reason we are not aware off to have csrf-protection on routes not found by flask? From our point of view, it should be ok to not handle csrf here and simply return a 404!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions