Fix a small bug on windows system#72
Open
hua-ops wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to run
prepare_data.pyon Windows System, I was having the error:assert len(ascii_sequences) == len(line_stroke_fnames) AssertionError. This is because on Windows system,os.path.join()gets the path concatenation character '\', so the path from line 50 ofprepare_data.pywould look like this:data/raw/ascii/z01\z01-000\z01-000z.txt, causing line 59 to be inaccessible and skipping the loop.By changing
fnames.append(os.path.join(dirpath, filename))withfnames.append(os.path.join(dirpath, filename).replace('\\', '/'))in line 50, the error removed, and successfully processed the data.