Update Pre Commit Hook Script

[Marto32]

This PR updates the pre-commit hook scripts:

• pre-commit.git-lint.sh
• pre-commit.hg-lint.sh

These changes are needed as the previous command to initialize git lint used xargs flags that were not available on OSX (namely --null and --no-run-if-empty). The updated scripts should perform the same functionality and will run on OSX.

This is addressed in issue #88

[coveralls]

Changes Unknown when pulling 5727349 on Marto32:mm/pre-commit-updates into ** on sk-:master**.

[sk-]

Thanks for the change. Could you update the PR, so that the change retains the same functionality as before.

[sk-]

Note that this is not exactly the same as the original script. The original script was linting only files being commited.

Here it should read something like:

echo $DIFF_FILES | xargs -0 git lint

The same applies for the mercurial hook.

[sk-]

Could you rename to something like DIFF_FILES.

[coveralls]

Changes Unknown when pulling 7092839 on Marto32:mm/pre-commit-updates into ** on sk-:master**.

[sk-]

Bash does not store new lines nor \0, so the above won't work. See http://stackoverflow.com/questions/6570531/assign-string-containing-null-character-0-to-a-variable-in-bash#answer-22985397

Apparently the only bullet proof solution is to save the result to a file, but that has the complications of deleting the temporary file even in case of errors.

Another alternative is to run the command twice. The first time to check whether the output is empty. And the second piped to xargs.

[Marto32]

Would it be possible to convert this to a python script and store those results as variables? Or does the hook have to be a shell script?

[Marto32]

@sk- I opted for the latter solution and used the variable to check if there is output, if there is, I reran the command and piped it into xargs. I tested the git script by running it manually line by line - works on OSX 10.11.6 (I did not test mercurial).

[coveralls]

Changes Unknown when pulling 7d93f36 on Marto32:mm/pre-commit-updates into ** on sk-:master**.

[Marto32]

@sk- circling back on this

[avoltz]

Is this PR still going?

This is a different change, but it seems to be working for me on OSX mojave. I think -L 1 has the same effect as --no-run-if-empty, but I'm not 100% sure.

Let me know if you want me to send a PR.

diff --git a/scripts/pre-commit.git-lint.sh b/scripts/pre-commit.git-lint.sh
index d432bdb..d1141b1 100755
--- a/scripts/pre-commit.git-lint.sh
+++ b/scripts/pre-commit.git-lint.sh
@@ -15,7 +15,7 @@

 # First part return the files being commited, excluding deleted files.
 git diff-index -z --cached HEAD --name-only --diff-filter=ACMRTUXB |
-xargs --null --no-run-if-empty git lint;
+xargs -0 -L 1 git lint;

 if [ "$?" != "0" ]; then
   echo "There are some problems with the modified files.";
diff --git a/scripts/pre-commit.hg-lint.sh b/scripts/pre-commit.hg-lint.sh
index 4a7cacf..d82785f 100644
--- a/scripts/pre-commit.hg-lint.sh
+++ b/scripts/pre-commit.hg-lint.sh
@@ -19,7 +19,7 @@ if [ "$NO_VERIFY" != "" ]; then
 fi

 hg status --change $HG_NODE | cut -b 3- | tr '\n' '\0' |
-xargs --null --no-run-if-empty git-lint;
+xargs -0 -L 1 git-lint;

 if [ "$?" != "0" ]; then
   echo "There are some problems with the modified files.";