-
Notifications
You must be signed in to change notification settings - Fork 1
Update Gradle from 7.1 to 8.14.3 #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: coolya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Gradle wrapper from version 7.1 (June 2021) to 8.14.3, representing a major version upgrade spanning approximately 4 years of improvements. The changes include updates to wrapper scripts, properties, and the wrapper JAR binary, along with new configuration properties for network timeout and distribution URL validation.
Key Changes:
- Updated Gradle distribution from 7.1 to 8.14.3
- Added security and network configuration properties (networkTimeout, validateDistributionUrl)
- Regenerated wrapper scripts with improved POSIX compliance and modernized logic
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updated distribution URL to 8.14.3 and added new timeout/validation properties |
| gradlew | Completely regenerated Unix shell script with enhanced POSIX compliance and modern argument handling |
| gradlew.bat | Updated Windows batch script with improved error handling and SPDX licensing |
| gradle/wrapper/gradle-wrapper.jar | Regenerated wrapper JAR binary for Gradle 8.14.3 compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| esac | ||
|
|
||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
| CLASSPATH="\\\"\\\"" |
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLASSPATH is set to escaped empty quotes instead of being empty or pointing to the gradle-wrapper.jar. This is incorrect and will cause the Java command at line 251 to fail since it tries to use this CLASSPATH with the -jar flag. The CLASSPATH should either be empty or properly reference the gradle-wrapper.jar path, but the current value of escaped quotes will break the execution.
| CLASSPATH="\\\"\\\"" | |
| CLASSPATH="" |
| set CLASSPATH= | ||
|
|
||
|
|
||
| @rem Execute Gradle | ||
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* |
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLASSPATH variable is set to empty instead of pointing to the gradle-wrapper.jar file. Line 77 attempts to use this empty CLASSPATH with the -classpath parameter while also using the -jar flag. When using -jar, the -classpath option is ignored, but this empty CLASSPATH combined with relying on -jar suggests inconsistency with how the wrapper is being invoked. The CLASSPATH should either be properly set or the invocation method should be clarified.
| set CLASSPATH= | |
| @rem Execute Gradle | |
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* | |
| @rem Execute Gradle | |
| "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* |
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env sh | |||
| #!/bin/sh | |||
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shebang has been changed from "#!/usr/bin/env sh" to "#!/bin/sh". While this is a valid change that comes with newer Gradle wrapper versions, it reduces portability compared to the env-based approach. The env-based shebang searches the PATH for sh, whereas the direct path requires sh to be at exactly /bin/sh. This change should be intentional and matches standard Gradle 8.x wrapper scripts, but it's worth noting this could affect systems where sh is installed in a non-standard location.
Upgrades Gradle wrapper from 7.1 (June 2021) to 8.14.3, bringing ~4 years of improvements including security fixes, performance enhancements, and better Java toolchain support.
Changes
gradle-8.14.3-bin.zip, added network timeout and URL validationgradle-wrapper.jar,gradlew, andgradlew.batvia./gradlew wrapper --gradle-version=8.14.3Compatibility
All existing plugins remain compatible (Kotlin 1.9.22, IntelliJ 1.17.4). Build scripts require no modifications. Gradle 9.0 deprecation warnings are expected but non-blocking.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
artifacts.itemis.cloud/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en(dns block)cache-redirector.jetbrains.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en(dns block)https://api.github.com/repos/JetBrains/intellij-platform-plugin-template/releases/latest/usr/bin/curl curl -s REDACTED(http block)maven.pkg.jetbrains.space/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.