-
Notifications
You must be signed in to change notification settings - Fork 34
BITE2 refactoring & testing #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PropzSaladaz
wants to merge
17
commits into
bite-2
Choose a base branch
from
enhancement/948-BITE2-CAT-refactor
base: bite-2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BiteManager is now mostly a glue layer that couples schain information with bite-related logic (things like thread executors, if sgx is enabled, if we want to use real crypto, totalSigners, requiredSigners, etc).
BiteManager keeps an isntance of BIteEngine that is initialized at the start, and holds state data itself.
Almost all code removals refer to moving code into its own file. This includes moving any serialization code into
BiteCodec, as well as moving most ofBiteManagerfunctions intoBiteEngine.By decoupling all Bite data from schain instances, we can now add tests specifically for Bite-related logic.
Also improved thread handling on destruction of consensus:
usleep. THis makes possible to stop the thread as soon as possible (which is the case during testing)logThreadLocal_causes SIGSEGV in unittests #967IMPORTANT
All bite-2 functionality is exactly the same apart for 1 or 2 bugs, identified from the added tests, that were fixed in this branch
Tests
Added tests for all Bite logic that was refactored:
Fixes #948