-
Notifications
You must be signed in to change notification settings - Fork 2
Migrate to ActiveSupport::Notifications #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
skatkov
wants to merge
12
commits into
main
Choose a base branch
from
use-notifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b6c8bd2
Migrate to ActiveSupport::Notifications
skatkov 1ceadb7
improve readme
skatkov f7ad5e8
Flexshing out details
skatkov ba34204
just small tweaks
skatkov eea3d2d
adjust initializer template
skatkov 37bc3f2
Optionally YARD document UndocumentedObjects
skatkov c443490
Include handler_event_id in instrumentation
skatkov de8626e
run mutant on CI only once
skatkov 5e99a88
add even payload example
skatkov 2e16b5f
Potential fix for pull request finding
skatkov 183ca89
BaseHandler now persists handler_module_name
skatkov d59821a
better looking processing_job
skatkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| name: mutation tests | ||
| on: [push, pull_request] | ||
| on: [pull_request] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,12 +11,12 @@ AllValidators: | |
| # Global file exclusion patterns | ||
| Exclude: | ||
| - '\.git' | ||
| - 'vendor/**/*' | ||
| - 'node_modules/**/*' | ||
| - 'spec/**/*' | ||
| - 'test/**/*' | ||
| - 'handler-examples/**/*' | ||
| - 'example/**/*' | ||
| - "vendor/**/*" | ||
| - "node_modules/**/*" | ||
| - "spec/**/*" | ||
| - "test/**/*" | ||
| - "handler-examples/**/*" | ||
| - "example/**/*" | ||
|
|
||
| # Exit code behavior (error, warning, convention, never) | ||
| FailOnSeverity: warning | ||
|
|
@@ -32,43 +32,43 @@ AllValidators: | |
|
|
||
| # Documentation validators | ||
| Documentation/UndocumentedObjects: | ||
| Description: 'Checks for classes, modules, and methods without documentation.' | ||
| Enabled: true | ||
| Description: "Checks for classes, modules, and methods without documentation." | ||
| Enabled: false | ||
|
Comment on lines
34
to
+36
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm mainly interested in yard tags for methods, so I can convert those into types. Object description is not that important. |
||
| Severity: warning | ||
| ExcludedMethods: | ||
| - 'initialize/0' # Exclude parameter-less initialize | ||
| - '/^_/' # Exclude private methods (by convention) | ||
| - "initialize/0" # Exclude parameter-less initialize | ||
| - "/^_/" # Exclude private methods (by convention) | ||
|
|
||
| Documentation/UndocumentedMethodArguments: | ||
| Description: 'Checks for method parameters without @param tags.' | ||
| Description: "Checks for method parameters without @param tags." | ||
| Enabled: true | ||
| Severity: warning | ||
|
|
||
| Documentation/UndocumentedBooleanMethods: | ||
| Description: 'Checks that question mark methods document their boolean return.' | ||
| Description: "Checks that question mark methods document their boolean return." | ||
| Enabled: true | ||
| Severity: warning | ||
|
|
||
| Documentation/UndocumentedOptions: | ||
| Description: 'Detects methods with options hash parameters but no @option tags.' | ||
| Description: "Detects methods with options hash parameters but no @option tags." | ||
| Enabled: true | ||
| Severity: warning | ||
|
|
||
| Documentation/MarkdownSyntax: | ||
| Description: 'Detects common markdown syntax errors in documentation.' | ||
| Description: "Detects common markdown syntax errors in documentation." | ||
| Enabled: true | ||
| Severity: warning | ||
|
|
||
| Documentation/EmptyCommentLine: | ||
| Description: 'Detects empty comment lines at the start or end of documentation blocks.' | ||
| Description: "Detects empty comment lines at the start or end of documentation blocks." | ||
| Enabled: true | ||
| Severity: convention | ||
| EnabledPatterns: | ||
| Leading: true | ||
| Trailing: true | ||
|
|
||
| Documentation/BlankLineBeforeDefinition: | ||
| Description: 'Detects blank lines between YARD documentation and method definition.' | ||
| Description: "Detects blank lines between YARD documentation and method definition." | ||
| Enabled: true | ||
| Severity: convention | ||
| OrphanedSeverity: convention | ||
|
|
@@ -78,7 +78,7 @@ Documentation/BlankLineBeforeDefinition: | |
|
|
||
| # Tags validators | ||
| Tags/Order: | ||
| Description: 'Enforces consistent ordering of YARD tags.' | ||
| Description: "Enforces consistent ordering of YARD tags." | ||
| Enabled: true | ||
| Severity: convention | ||
| EnforcedOrder: | ||
|
|
@@ -95,7 +95,7 @@ Tags/Order: | |
| - todo | ||
|
|
||
| Tags/InvalidTypes: | ||
| Description: 'Validates type definitions in @param, @return, @option tags.' | ||
| Description: "Validates type definitions in @param, @return, @option tags." | ||
| Enabled: true | ||
| Severity: warning | ||
| ValidatedTags: | ||
|
|
@@ -104,7 +104,7 @@ Tags/InvalidTypes: | |
| - return | ||
|
|
||
| Tags/TypeSyntax: | ||
| Description: 'Validates YARD type syntax using YARD parser.' | ||
| Description: "Validates YARD type syntax using YARD parser." | ||
| Enabled: true | ||
| Severity: warning | ||
| ValidatedTags: | ||
|
|
@@ -114,7 +114,7 @@ Tags/TypeSyntax: | |
| - yieldreturn | ||
|
|
||
| Tags/MeaninglessTag: | ||
| Description: 'Detects @param/@option tags on classes, modules, or constants.' | ||
| Description: "Detects @param/@option tags on classes, modules, or constants." | ||
| Enabled: true | ||
| Severity: warning | ||
| CheckedTags: | ||
|
|
@@ -126,18 +126,18 @@ Tags/MeaninglessTag: | |
| - constant | ||
|
|
||
| Tags/CollectionType: | ||
| Description: 'Validates Hash collection syntax consistency.' | ||
| Description: "Validates Hash collection syntax consistency." | ||
| Enabled: true | ||
| Severity: convention | ||
| EnforcedStyle: long # 'long' for Hash{K => V} (YARD standard), 'short' for {K => V} | ||
| EnforcedStyle: long # 'long' for Hash{K => V} (YARD standard), 'short' for {K => V} | ||
| ValidatedTags: | ||
| - param | ||
| - option | ||
| - return | ||
| - yieldreturn | ||
|
|
||
| Tags/TagTypePosition: | ||
| Description: 'Validates type annotation position in tags.' | ||
| Description: "Validates type annotation position in tags." | ||
| Enabled: true | ||
| Severity: convention | ||
| CheckedTags: | ||
|
|
@@ -148,26 +148,26 @@ Tags/TagTypePosition: | |
| EnforcedStyle: type_after_name | ||
|
|
||
| Tags/ApiTags: | ||
| Description: 'Enforces @api tags on public objects.' | ||
| Enabled: false # Opt-in validator | ||
| Description: "Enforces @api tags on public objects." | ||
| Enabled: false # Opt-in validator | ||
| Severity: warning | ||
| AllowedApis: | ||
| - public | ||
| - private | ||
| - internal | ||
|
|
||
| Tags/OptionTags: | ||
| Description: 'Requires @option tags for methods with options parameters.' | ||
| Description: "Requires @option tags for methods with options parameters." | ||
| Enabled: true | ||
| Severity: warning | ||
|
|
||
| Tags/ExampleSyntax: | ||
| Description: 'Validates Ruby syntax in @example tags.' | ||
| Description: "Validates Ruby syntax in @example tags." | ||
| Enabled: true | ||
| Severity: warning | ||
|
|
||
| Tags/RedundantParamDescription: | ||
| Description: 'Detects meaningless parameter descriptions that add no value.' | ||
| Description: "Detects meaningless parameter descriptions that add no value." | ||
| Enabled: true | ||
| Severity: convention | ||
| CheckedTags: | ||
|
|
@@ -204,23 +204,23 @@ Tags/InformalNotation: | |
| CaseSensitive: false | ||
| RequireStartOfLine: true | ||
| Patterns: | ||
| Note: '@note' | ||
| Todo: '@todo' | ||
| TODO: '@todo' | ||
| FIXME: '@todo' | ||
| See: '@see' | ||
| See also: '@see' | ||
| Warning: '@deprecated' | ||
| Deprecated: '@deprecated' | ||
| Author: '@author' | ||
| Version: '@version' | ||
| Since: '@since' | ||
| Returns: '@return' | ||
| Raises: '@raise' | ||
| Example: '@example' | ||
| Note: "@note" | ||
| Todo: "@todo" | ||
| TODO: "@todo" | ||
| FIXME: "@todo" | ||
| See: "@see" | ||
| See also: "@see" | ||
| Warning: "@deprecated" | ||
| Deprecated: "@deprecated" | ||
| Author: "@author" | ||
| Version: "@version" | ||
| Since: "@since" | ||
| Returns: "@return" | ||
| Raises: "@raise" | ||
| Example: "@example" | ||
|
|
||
| Tags/NonAsciiType: | ||
| Description: 'Detects non-ASCII characters in type annotations.' | ||
| Description: "Detects non-ASCII characters in type annotations." | ||
| Enabled: true | ||
| Severity: warning | ||
| ValidatedTags: | ||
|
|
@@ -231,8 +231,8 @@ Tags/NonAsciiType: | |
| - yieldparam | ||
|
|
||
| Tags/TagGroupSeparator: | ||
| Description: 'Enforces blank line separators between different YARD tag groups.' | ||
| Enabled: false # Opt-in validator | ||
| Description: "Enforces blank line separators between different YARD tag groups." | ||
| Enabled: false # Opt-in validator | ||
| Severity: convention | ||
| TagGroups: | ||
| param: [param, option] | ||
|
|
@@ -244,8 +244,8 @@ Tags/TagGroupSeparator: | |
| RequireAfterDescription: false | ||
|
|
||
| Tags/ForbiddenTags: | ||
| Description: 'Detects forbidden tag and type combinations.' | ||
| Enabled: false # Opt-in validator | ||
| Description: "Detects forbidden tag and type combinations." | ||
| Enabled: false # Opt-in validator | ||
| Severity: convention | ||
| ForbiddenPatterns: [] | ||
| # Example patterns: | ||
|
|
@@ -259,37 +259,37 @@ Tags/ForbiddenTags: | |
|
|
||
| # Warnings validators - catches YARD parser errors | ||
| Warnings/UnknownTag: | ||
| Description: 'Detects unknown YARD tags.' | ||
| Description: "Detects unknown YARD tags." | ||
| Enabled: true | ||
| Severity: error | ||
|
|
||
| Warnings/UnknownDirective: | ||
| Description: 'Detects unknown YARD directives.' | ||
| Description: "Detects unknown YARD directives." | ||
| Enabled: true | ||
| Severity: error | ||
|
|
||
| Warnings/InvalidTagFormat: | ||
| Description: 'Detects malformed tag syntax.' | ||
| Description: "Detects malformed tag syntax." | ||
| Enabled: true | ||
| Severity: error | ||
|
|
||
| Warnings/InvalidDirectiveFormat: | ||
| Description: 'Detects malformed directive syntax.' | ||
| Description: "Detects malformed directive syntax." | ||
| Enabled: true | ||
| Severity: error | ||
|
|
||
| Warnings/DuplicatedParameterName: | ||
| Description: 'Detects duplicate @param tags.' | ||
| Description: "Detects duplicate @param tags." | ||
| Enabled: true | ||
| Severity: error | ||
|
|
||
| Warnings/UnknownParameterName: | ||
| Description: 'Detects @param tags for non-existent parameters.' | ||
| Description: "Detects @param tags for non-existent parameters." | ||
| Enabled: true | ||
| Severity: error | ||
|
|
||
| # Semantic validators | ||
| Semantic/AbstractMethods: | ||
| Description: 'Ensures @abstract methods do not have real implementations.' | ||
| Description: "Ensures @abstract methods do not have real implementations." | ||
| Enabled: true | ||
| Severity: warning | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.