Skip to content

[25147][25177] Home bottom sheet UI alignment and dynamic font configuration#523

Open
MichaelReyes wants to merge 8 commits intodevelopfrom
task/25147-UI-alignment
Open

[25147][25177] Home bottom sheet UI alignment and dynamic font configuration#523
MichaelReyes wants to merge 8 commits intodevelopfrom
task/25147-UI-alignment

Conversation

@MichaelReyes
Copy link
Copy Markdown
Contributor

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • Jetpack compose integration
  • Home bottom sheet cards UI alignment
  • migration of home bottom sheet cards to Jetpack compose

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

- add jetpack compose gradle configuration
- setup compose themes
- add bindFavoriteRowCompose.kt and FavoriteRow to jetpack compose implementation of the FavoriteHomeItemManager UI
@github-actions
Copy link
Copy Markdown

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

Copy link
Copy Markdown
Contributor

@sg-jsonjuliane sg-jsonjuliane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-actions
Copy link
Copy Markdown

This pull request is stale because it has been open 5 days with no activity.

@github-actions github-actions Bot added the Stale label Feb 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 3, 2026

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@github-actions github-actions Bot removed the Stale label Mar 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026

This pull request is stale because it has been open 5 days with no activity.

@github-actions github-actions Bot added the Stale label Mar 9, 2026
@github-actions
Copy link
Copy Markdown

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@github-actions github-actions Bot removed the Stale label Mar 11, 2026
@github-actions
Copy link
Copy Markdown

This pull request is stale because it has been open 5 days with no activity.

@github-actions github-actions Bot added the Stale label Mar 16, 2026
@github-actions
Copy link
Copy Markdown

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@github-actions github-actions Bot removed the Stale label Mar 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2026

This pull request is stale because it has been open 5 days with no activity.

@github-actions github-actions Bot added the Stale label Apr 5, 2026
@github-actions
Copy link
Copy Markdown

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@github-actions github-actions Bot removed the Stale label Apr 11, 2026
@github-actions
Copy link
Copy Markdown

This pull request is stale because it has been open 5 days with no activity.

@github-actions github-actions Bot added the Stale label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants