Feature: adds translate option to the useFloating hook #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To not interfere with other transform animation, this allows to set the position state through the 'translate' property instead of 'transform'
To facilitate transition and animation, includes the transition-origin in the floating styles when using translate or transform
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Here a reproduction link in svelte playground. And here a reproduction repo on github.. To replicate the issue, a refresh or a window resize is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the
transformproperty for positionning might interfer with animations or make merging of states complex.For example, the use of a enter/exit animations such as the svlete native
scaletransition will overwrite the transform property during transition.A workaround is to use absolute positioning, but this can also causes issues (e.g. content shift) and tends to be less performant.
This PR propose to uses the
translateproperty instead which has achieved a high level of support (94-95%) in recent years.This also adds
transform-originwhen using translate/transform to facilitate animation and transitions.