-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/input-chip-add-remove-manually #2347
feat/input-chip-add-remove-manually #2347
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4960690 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Mahmoud-zino I somehow completely missed this, so I'll plan to review and merge between now and the next release. My bad! |
@Mahmoud-zino I haven't forgot your PR here, just been too swamped to devote proper time to it. I hope to rectify that soon. I do think we'll move forward with this if I can confirm all is well. |
@Mahmoud-zino just had a look at this. The functionality is great! Just a couple minor things:
2 Additionally, per the documentation, instead of saying "manually" here, can we say "programmatically" please? |
@Mahmoud-zino one more thing....can you make the numbers random values between say 1-10,000? I think it'll look nicer than the decimal values. But super nitpicky, don't stress about it you don't have time. We can evaluate again when we port to v3. |
@Mahmoud-zino perfect, thanks! |
Linked Issue
Closes #2293
Description
implemented exported functions add/remove chip to manually add-remove chip.
@endigo9740
Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test