Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: input chip select aria #2445

Merged

Conversation

Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #2440

Description

added labelSelect to provide aria-label on input-chip select

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Jan 27, 2024

🦋 Changeset detected

Latest commit: c8c3f55

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jan 27, 2024 5:51pm

@endigo9740
Copy link
Contributor

@Mahmoud-zino I've change this from labelSelect to label to be consistent with our ARIA prop naming convention. We just drop the aria- portion and the remainder is the prop name. See a reference here:

https://github.com/skeletonlabs/skeleton/blob/master/packages/skeleton/src/lib/components/RangeSlider/RangeSlider.svelte#L38

I'll marge this now. Thanks!

@endigo9740 endigo9740 merged commit c283b12 into skeletonlabs:dev Jan 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputChip Lighthouse Accessibility
2 participants