Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/remove superflous styles from chips and cards docs #2464

Conversation

TazorDE
Copy link
Member

@TazorDE TazorDE commented Feb 3, 2024

Linked Issue

Closes #2463

Description

Removes superfluous styles from Chips and Cards documentation pages that could potentially confuse users

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Feb 3, 2024

🦋 Changeset detected

Latest commit: e01ec63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
skeleton.dev Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Feb 3, 2024 7:35pm

@TazorDE TazorDE added this to the v2.0 milestone Feb 3, 2024
@TazorDE TazorDE added the documentation Improvements or additions to documentation label Feb 3, 2024
@endigo9740
Copy link
Contributor

You rock dude, thanks! I'll review this asap

@TazorDE TazorDE changed the title remove superflous styles from chips and cards docs chore/remove superflous styles from chips and cards docs Feb 4, 2024
@endigo9740 endigo9740 merged commit 6c31f1b into skeletonlabs:dev Feb 8, 2024
4 checks passed
@TazorDE TazorDE deleted the chore/remove-not-provided-styles-from-docs branch February 11, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong styles advertised for several Tailwind elements
2 participants