Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/remove label prop in progress bar docs #2545

Conversation

esaltzm1
Copy link

@esaltzm1 esaltzm1 commented Mar 12, 2024

Linked Issue

Closes #2516

Description

This PR removes the label prop from the example code within the documentation for the ProgressBar component. There is no label prop in the ProgressBar component.

link to ProgressBar and its props: https://github.com/skeletonlabs/skeleton/blob/dev/packages/skeleton/src/lib/components/ProgressBar/ProgressBar.svelte

link to documentation: https://www.skeleton.dev/components/progress-bars

Note: the linting problems are in files I did not touch. Let me know if it's helpful for me to include lint fixes for those files in this PR.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: c829b30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Mar 12, 2024 8:29pm

Copy link

vercel bot commented Mar 12, 2024

@esaltzm1 is attempting to deploy a commit to the Skeleton Labs Team on Vercel.

A member of the Team first needs to authorize it.

@endigo9740
Copy link
Contributor

This is great, thank you @esaltzm1

@endigo9740 endigo9740 merged commit ff0380c into skeletonlabs:dev Mar 12, 2024
3 of 6 checks passed
@esaltzm1 esaltzm1 deleted the docs/remove-label-prop-in-progress-bar-docs branch March 13, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants