Skip to content

Conversation

Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Oct 9, 2025

Description

Implements the Skeleton MCP

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changesets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 18:17
Copy link

changeset-bot bot commented Oct 9, 2025

🦋 Changeset detected

Latest commit: 0d9149c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@skeletonlabs/skeleton-mcp Patch
skeleton Patch
@skeletonlabs/skeleton-common Patch
@skeletonlabs/skeleton-react Patch
@skeletonlabs/skeleton-svelte Patch
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
themes.skeleton.dev Building Building Preview Comment Oct 13, 2025 6:44pm
www.skeleton.dev Ready Ready Preview Comment Oct 13, 2025 6:44pm

@Hugos68 Hugos68 changed the title Feat/skeleton mcp feat: mcp Oct 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a skeleton MCP (Model Context Protocol) server for the Skeleton framework. It adds a new package to provide MCP-based tooling for listing frameworks and components.

  • Adds a new skeleton-mcp package with basic MCP server infrastructure
  • Implements placeholder tools for listing frameworks and components
  • Updates workspace configuration to include new dependencies

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Adds MCP SDK and Zod dependencies to the catalog
packages/skeleton-mcp/package.json Package configuration for the new MCP server
packages/skeleton-mcp/tsconfig.json TypeScript configuration for the MCP package
packages/skeleton-mcp/src/mcp-server.ts Core MCP server initialization
packages/skeleton-mcp/src/index.ts Main entry point with stdio transport setup
packages/skeleton-mcp/src/tools/list-frameworks.ts Placeholder tool for listing frameworks
packages/skeleton-mcp/src/tools/list-components.ts Placeholder tool for listing components
.changeset/pre.json Adds the new package to changeset tracking
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +10 to +11
return {
content: [],
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The tool returns an empty array without any implementation. Consider adding a TODO comment or implementing basic functionality to make the tool useful.

Suggested change
return {
content: [],
// TODO: Replace with dynamic framework listing logic.
return {
content: [
{ name: 'React', description: 'A JavaScript library for building user interfaces.' },
{ name: 'Vue', description: 'The Progressive JavaScript Framework.' },
{ name: 'Angular', description: 'One framework. Mobile & desktop.' },
],

Copilot uses AI. Check for mistakes.

Comment on lines 9 to 13
async () => {
return {
content: [],
};
},
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The tool returns an empty array without any implementation. Consider adding a TODO comment or implementing basic functionality to make the tool useful.

Copilot uses AI. Check for mistakes.

@@ -0,0 +1,13 @@
import { server } from '@/mcp-server';
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools are not imported, so they won't be registered with the server. Add imports for the tool files to ensure they are loaded and registered.

Copilot uses AI. Check for mistakes.

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 18:22
@vercel vercel bot temporarily deployed to Preview – themes.skeleton.dev October 9, 2025 18:23 Inactive
@vercel vercel bot temporarily deployed to Preview – www.skeleton.dev October 9, 2025 18:23 Inactive
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 3 to 14
server.registerTool(
'list_frameworks',
{
title: 'List Frameworks',
description: 'Lists all frameworks available in Skeleton',
},
async () => {
return {
content: [],
};
},
);
Copy link

Copilot AI Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tool registration is executed at module import time, creating a side effect. Consider exporting a registration function instead and calling it explicitly from the main entry point to make the initialization more explicit and testable.

Suggested change
server.registerTool(
'list_frameworks',
{
title: 'List Frameworks',
description: 'Lists all frameworks available in Skeleton',
},
async () => {
return {
content: [],
};
},
);
export function registerListFrameworksTool() {
server.registerTool(
'list_frameworks',
{
title: 'List Frameworks',
description: 'Lists all frameworks available in Skeleton',
},
async () => {
return {
content: [],
};
},
);
}

Copilot uses AI. Check for mistakes.

@vercel vercel bot temporarily deployed to Preview – www.skeleton.dev October 9, 2025 18:24 Inactive
@vercel vercel bot temporarily deployed to Preview – themes.skeleton.dev October 9, 2025 18:24 Inactive
@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 18:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant