-
-
Notifications
You must be signed in to change notification settings - Fork 363
feat: mcp #3897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: mcp #3897
Conversation
🦋 Changeset detectedLatest commit: 0d9149c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a skeleton MCP (Model Context Protocol) server for the Skeleton framework. It adds a new package to provide MCP-based tooling for listing frameworks and components.
- Adds a new
skeleton-mcp
package with basic MCP server infrastructure - Implements placeholder tools for listing frameworks and components
- Updates workspace configuration to include new dependencies
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
pnpm-workspace.yaml | Adds MCP SDK and Zod dependencies to the catalog |
packages/skeleton-mcp/package.json | Package configuration for the new MCP server |
packages/skeleton-mcp/tsconfig.json | TypeScript configuration for the MCP package |
packages/skeleton-mcp/src/mcp-server.ts | Core MCP server initialization |
packages/skeleton-mcp/src/index.ts | Main entry point with stdio transport setup |
packages/skeleton-mcp/src/tools/list-frameworks.ts | Placeholder tool for listing frameworks |
packages/skeleton-mcp/src/tools/list-components.ts | Placeholder tool for listing components |
.changeset/pre.json | Adds the new package to changeset tracking |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
return { | ||
content: [], |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The tool returns an empty array without any implementation. Consider adding a TODO comment or implementing basic functionality to make the tool useful.
return { | |
content: [], | |
// TODO: Replace with dynamic framework listing logic. | |
return { | |
content: [ | |
{ name: 'React', description: 'A JavaScript library for building user interfaces.' }, | |
{ name: 'Vue', description: 'The Progressive JavaScript Framework.' }, | |
{ name: 'Angular', description: 'One framework. Mobile & desktop.' }, | |
], |
Copilot uses AI. Check for mistakes.
async () => { | ||
return { | ||
content: [], | ||
}; | ||
}, |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The tool returns an empty array without any implementation. Consider adding a TODO comment or implementing basic functionality to make the tool useful.
Copilot uses AI. Check for mistakes.
@@ -0,0 +1,13 @@ | |||
import { server } from '@/mcp-server'; |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tools are not imported, so they won't be registered with the server. Add imports for the tool files to ensure they are loaded and registered.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
server.registerTool( | ||
'list_frameworks', | ||
{ | ||
title: 'List Frameworks', | ||
description: 'Lists all frameworks available in Skeleton', | ||
}, | ||
async () => { | ||
return { | ||
content: [], | ||
}; | ||
}, | ||
); |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tool registration is executed at module import time, creating a side effect. Consider exporting a registration function instead and calling it explicitly from the main entry point to make the initialization more explicit and testable.
server.registerTool( | |
'list_frameworks', | |
{ | |
title: 'List Frameworks', | |
description: 'Lists all frameworks available in Skeleton', | |
}, | |
async () => { | |
return { | |
content: [], | |
}; | |
}, | |
); | |
export function registerListFrameworksTool() { | |
server.registerTool( | |
'list_frameworks', | |
{ | |
title: 'List Frameworks', | |
description: 'Lists all frameworks available in Skeleton', | |
}, | |
async () => { | |
return { | |
content: [], | |
}; | |
}, | |
); | |
} |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
Implements the Skeleton MCP
Checklist
Please read and apply all contribution requirements.
docs/
,feature/
,chore/
,bugfix/
main
branchpnpm check
in the root of the monorepopnpm format
in the root of the monorepopnpm lint
in the root of the monorepopnpm test
in the root of the monorepo/package
projects, please supply a ChangesetChangesets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changeset
and follow the prompts