Skip to content

Conversation

@AdeboyeDN
Copy link

@AdeboyeDN AdeboyeDN commented Jan 12, 2026

Linked Issue

Closes #4239

Description

This addresses issue #4239 where selected items in the ComboBox were
hard to read when reopening the dropdown.

AI Disclosure

Use of LLM technology is allowed. We ask for your voluntary disclosure to help inform future Skeleton contribution guidelines.

  • I used AI to generate this pull request

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, task/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changesets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR ready for review.

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2026

🦋 Changeset detected

Latest commit: 05cd879

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@skeletonlabs/skeleton-common Patch
@skeletonlabs/skeleton-react Patch
@skeletonlabs/skeleton-svelte Patch
skeleton Patch
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
www.skeleton.dev Ready Ready Preview Jan 14, 2026 9:25pm

Copy link
Contributor

@endigo9740 endigo9740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdeboyeDN typically when we see contributions that are using outdated information, it's due to AI contribution. We ask that users volunteer their use of LLMs as part of the PR submission process here:
#4250 (comment)

So either your LLM is using outdated information, or you have somehow draw information from an old documentation source. Make sure you're always using the current/modern docs at this URL:

https://www.skeleton.dev/
(Older docs have v2, v3, specified in the URL)

If you are making use of LLMs, that's fine, just make sure you:

  1. Disclose this information per our request (you can edit the PR post)
  2. Are feeding it the correct LLM source, which is available here:

https://www.skeleton.dev/docs/svelte/resources/llms

I'll go ahead and give you a chance to rectify this, but if the issue is not solved, and correct properties and protocols used, then I will have to deny and close this PR.

Thanks for your understanding.

@AdeboyeDN
Copy link
Author

Hi @endigo9740 , apologies, I’ve addressed your comments. Let me know what you think.

Copy link
Contributor

@endigo9740 endigo9740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AdeboyeDN - sorry for the delay. I'd submitted this review last week, but forgot to submit it. Let me know if you have any questions.


&[data-highlighted] {
@apply preset-tonal;
color: var(--color-surface-contrast-950);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AdeboyeDN thanks for the quick turn around here.

While this is a step in the right direction. I had mentioned the issue with using a fixed color and trying to address this in the combobox styles prior. For one, your solution improves dark mode - but here's light mode now:

Screenshot 2026-01-15 at 8 40 55 AM

Your current fix is aimed at addressing the issue localized to the combobox. If we were going to do that, we would need to use a color pairing to address both modes like so:

color: var(--color-surface-contrast-950-50);

Which would use this value:

https://github.com/skeletonlabs/skeleton/blob/main/packages/skeleton/src/base/theme.css#L388

Unfortunately this is not a broad enough change. The core issue is that preset-tonal should in fact handle the color values automatically. This means the issue is in the preset itself. If we take a look here, we can see what I mean:

https://github.com/skeletonlabs/skeleton/blob/main/packages/skeleton/src/utilities/presets.css#L331

Unlike the other Tonal presets, the generic preset-tonal doesn't have color values set. So essentially we need to fix the color in the preset, not in the combobox styling:

@utility preset-tonal {
	background-color: color-mix(in oklab, light-dark(var(--color-surface-950), var(--color-surface-50)) 5%, transparent);
	color: var(--color-surface-contrast-950-50); /* <--- add this */
}

This will not only fix the combobox issue, but should ensure the preset works as expected in many different use cases. If you could please, remove the combobox style change, add the change to the preset, and update your changeset. That would be great. In this case the changeset will need two changes:

  • Switch from skeleton-common to skeleton
  • Update the description to describe the change to the preset

Please and thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBox selected element using wrong color

2 participants