Skip to content

Fixes plugin following Sketchfab API change #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AurL wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes plugin following Sketchfab API change #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b992b4b
[#D3D-6403] Fixes plugin issue with last Sketchfab API changes
AurL Mar 30, 2022
5049853
[#D3D-6403] Bumps plugin version to 1.2.2
AurL Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions UnityGLTF/Assets/UnityGLTF/Scripts/Sketchfab/AssetBrowser/SketchfabBrowserManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,16 @@ private void parseFromNode(JSONNode node)
uid = node["uid"];
vertexCount = node["vertexCount"].AsInt;
faceCount = node["faceCount"].AsInt;
archiveSize = node["archives"]["gltf"]["size"].AsInt;

JSONArray archives = node["archives"].AsArray;
foreach (JSONNode archive in archives)
{
if ((string)archive["type"] == "gltf")
{
archiveSize = archive["size"].AsInt;
return;
}
}
}

private string richifyText(string text)
Expand Down Expand Up @@ -139,7 +148,7 @@ public class SketchfabBrowserManager
Dictionary<string, string> _categories;

// Search
private const string INITIAL_SEARCH = "type=models&downloadable=true&staffpicked=true&min_face_count=1&sort_by=-publishedAt";
private const string INITIAL_SEARCH = "type=models&downloadable=true&available_archive_type=gltf&staffpicked=true&min_face_count=1&sort_by=-publishedAt";
string _lastQuery;
string _prevCursorUrl = "";
string _nextCursorUrl = "";
Expand Down Expand Up @@ -336,7 +345,7 @@ public void search(string query, bool staffpicked, bool animated, string categor
if (endpoint != SEARCH_ENDPOINT.STORE_PURCHASES)
{
// Apply default filters
searchQuery = searchQuery + "type=models&downloadable=true";
searchQuery = searchQuery + "type=models&downloadable=true&available_archive_type=gltf";
}

if (query.Length > 0)
Expand Down
2 changes: 1 addition & 1 deletion UnityGLTF/Assets/UnityGLTF/Scripts/Sketchfab/SketchfabPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ namespace Sketchfab
{
public class SketchfabPlugin : MonoBehaviour
{
public static string VERSION = "1.2.1";
public static string VERSION = "1.2.2";

public struct Urls
{
Expand Down