Skip to content

feat(shell): readd completions (#726)#739

Merged
LoricAndre merged 6 commits intomasterfrom
feat/readd-completions
Apr 27, 2025
Merged

feat(shell): readd completions (#726)#739
LoricAndre merged 6 commits intomasterfrom
feat/readd-completions

Conversation

@LoricAndre
Copy link
Contributor

@LoricAndre LoricAndre commented Apr 26, 2025

Checklist

check the box if it is not applicable to your changes

  • I have updated the README with the necessary documentation
  • I have added unit tests
  • I have added end-to-end tests
  • I have linked all related issues or PRs

Description of the changes

@LoricAndre
Copy link
Contributor Author

@n8henrie could you download the key-bindings.bash from this PR, source it and tell me what you get ? I tried readding it, but I'm not using bash as my shell atm and not sure if what the few quirks I see is a result of my config or not.

@LoricAndre LoricAndre force-pushed the feat/readd-completions branch from 33265d0 to 3e8b08a Compare April 26, 2025 21:17
@n8henrie
Copy link
Contributor

Downloading and sourcing just that file (in a shell with sk available), it seems to work as hoped. Thanks so much!

@LoricAndre LoricAndre merged commit f87ff67 into master Apr 27, 2025
20 checks passed
@LoricAndre LoricAndre deleted the feat/readd-completions branch April 27, 2025 21:12
This was referenced May 4, 2025
This was referenced May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants