Feature: add support for cycle flag #802
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
check the box if it is not applicable to your changes
Description of the changes
From this issue #553
When the --cycle flag is provided, going down from the first item will go to the last item, and going up from the last item will go to the first item.
Functions similarly to fzf, so it will only cycle from that item. That is, if page down is pressed, the selection will stop at the first item, and pressing it again will cycle
This adds fixes discussed in #796 (comment). I accidentally closed my previous PR when trying to fix it, as I am still learning how to use git correctly