Conversation
|
Don't sell yourself short, this is definitely a feature. Thanks for taking a look ! In the meantime, I'll try to think about some way to run tests without needing tmux, probably using cargo-insta and Ratatui's TestBackend |
60411f7 to
45af155
Compare
|
Made tmux support Unix-only (module gated with cfg(unix) and the --tmux clap flag hidden on non-Unix). On Windows, passing --tmux is rejected, and tests/e2e_filter.rs asserts both behaviors. |
@LoricAndre, out of curiosity, do you use tmux to also test colored output? |
|
Yes, but the tests involving ANSI coloring are very tedious and prone to break quite easily, since the actual escape codes will vary depending on the platform and/or terminal emulator. I migrated most of our tests to use ratatui's testbackend and cargo-insta but those cannot capture colors AFAIK unfortunately |
45af155 to
80bfbfe
Compare
|
Please make sure to rebase, I've made pretty heavy changes to the tests and they might impact you (in particular, most tests files are now cross-platform) |
96f9dd9 to
276ff40
Compare
Checklist
check the box if it is not applicable to your changes
Description of the changes
Summary:
Testing (local, Windows):
Testing (fork CI):
Fixes #293