feat: allow run_with to be run within a tokio runtime#979
Merged
LoricAndre merged 2 commits intoskim-rs:masterfrom Feb 17, 2026
Merged
feat: allow run_with to be run within a tokio runtime#979LoricAndre merged 2 commits intoskim-rs:masterfrom
LoricAndre merged 2 commits intoskim-rs:masterfrom
Conversation
Contributor
|
Thank you for this, could you add an |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
The tests ran fine locally on my machine. I only got some timeouts that didn't seem related to tokio |
Contributor
|
You're right, I actually fixed the need for the Tokio runtime without noticing, sorry |
Contributor
|
This looks perfect, I was wondering whether this was possible or not. I'm planning a release tomorrow, so you should have this available in 3.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
README.md, comments,src/manpage.rsand/orsrc/options.rsif applicable)Description of the changes
Note: codecov runs on the PR on this repo, but feel free to ignore it.