Skip to content

feat: allow run_with to be run within a tokio runtime#979

Merged
LoricAndre merged 2 commits intoskim-rs:masterfrom
figsoda:tokio
Feb 17, 2026
Merged

feat: allow run_with to be run within a tokio runtime#979
LoricAndre merged 2 commits intoskim-rs:masterfrom
figsoda:tokio

Conversation

@figsoda
Copy link
Contributor

@figsoda figsoda commented Feb 17, 2026

Checklist

  • The title of my PR follows conventional commits
  • I have updated the documentation (README.md, comments, src/manpage.rs and/or src/options.rs if applicable)
  • I have added unit tests
  • I have added integration tests
  • I have linked all related issues or PRs

Description of the changes

Note: codecov runs on the PR on this repo, but feel free to ignore it.

@LoricAndre
Copy link
Contributor

Thank you for this, could you add an async example using run_with from inside a tokio::main ?

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/lib.rs 33.33% 1 Missing and 3 partials ⚠️

📢 Thoughts on this report? Let us know!

@figsoda
Copy link
Contributor Author

figsoda commented Feb 17, 2026

Also, I'm quite sure the tests will fail as init_tui needs a Tokio runtime to work.

The tests ran fine locally on my machine. I only got some timeouts that didn't seem related to tokio

@LoricAndre
Copy link
Contributor

You're right, I actually fixed the need for the Tokio runtime without noticing, sorry

@LoricAndre LoricAndre enabled auto-merge (squash) February 17, 2026 20:54
@LoricAndre
Copy link
Contributor

This looks perfect, I was wondering whether this was possible or not. I'm planning a release tomorrow, so you should have this available in 3.3.0

@LoricAndre LoricAndre disabled auto-merge February 17, 2026 20:55
@LoricAndre LoricAndre enabled auto-merge (squash) February 17, 2026 20:56
@LoricAndre LoricAndre merged commit 2a7bd1d into skim-rs:master Feb 17, 2026
14 checks passed
@figsoda figsoda deleted the tokio branch February 17, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants