This repository was archived by the owner on Apr 26, 2025. It is now read-only.
Open
Conversation
c4eater
force-pushed
the
disable-leading-newline
branch
from
532b922 to
08c9ab2
Compare
c4eater
force-pushed
the
disable-leading-newline
branch
from
08c9ab2 to
d9c6612
Compare
This change adds a new TermOption, "has_leading_newline". When this option is set to false (default is true), TermLock::ensure_height() does not add a leading newline (=the separator between the original line contents and the new contents) to the output anymore. When it is set to true, there is no change in ensure_height()'s behavior (the leading newline is present).
c4eater
force-pushed
the
disable-leading-newline
branch
from
d9c6612 to
7b8260f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new TermOption, "has_leading_newline".
When this option is set to false (default is true), TermLock::ensure_height() would not add a leading newline (=the separator between the original line contents and the new contents) to the output anymore.
When it is set to true, there is no change in ensure_height()'s behavior (the leading newline is present).
I'm using this option and setting it to false in my version of skim (https://github.com/c4eater/skim/tree/disable-leading-newline) because the output looks better without the leading newline.
Here are some screenshots of skim with and without the leading newline:
If has_leading_newline is false:
If has_leading_newline is true (default):