Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4b34db6 to
8ccb0e8
Compare
Eric-Warehime
approved these changes
Sep 11, 2025
| 1. Rename the `contrib/digitalocean/petri_docker.pkr.hcl.example` file to `contrib/digitalocean/petri_docker.pkr.hcl` | ||
| 2. Replace `<DO_API_TOKEN>` with your DigitalOcean API token | ||
| 3. Replace `<GRAF_PYRO_USER>` and `<GRAF_PYRO_PASS>` in `config.alloy` with your Grafana username and password for Pyroscope profiling data publication. | ||
| 3. Replace `<GRAF_PYRO_USER>`, `<GRAF_PYRO_PASS>`,`<GRAF_LOKI_USER>`, `<GRAF_LOKI_PASS>`,`<GRAF_OTLP_USER>`, `<GRAF_OTLP_PASS>` in `config.alloy` with your Grafana username and password for Pyroscope profiling data publication. |
Contributor
There was a problem hiding this comment.
So you need grafana admin to create the images yes?
Contributor
Author
There was a problem hiding this comment.
yeah thats correct
Comment on lines
+270
to
+280
| amount := "" | ||
| for i, coin := range genesisAmounts { | ||
| if i != 0 { | ||
| amount += "," | ||
| } | ||
| amount += fmt.Sprintf("%s%s", coin.Amount.String(), coin.Denom) | ||
| } | ||
|
|
||
| var addGenesisAccountCmd []string | ||
| if n.GetChainConfig().UseGenesisSubCommand { | ||
| addGenesisAccountCmd = append(addGenesisAccountCmd, "genesis") |
Contributor
There was a problem hiding this comment.
This is the same logic as executed above. Why do we need to write this code in multiple places?
Contributor
Author
There was a problem hiding this comment.
the validator which collect-gentxs is run on has to have the other accounts in its genesis state otherwise it will fail to recognize the account
Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.