Skip to content

Comments

chore: speed up workflow#98

Merged
nadim-az merged 22 commits intomainfrom
na/run-cmds-scripts
Sep 11, 2025
Merged

chore: speed up workflow#98
nadim-az merged 22 commits intomainfrom
na/run-cmds-scripts

Conversation

@nadim-az
Copy link
Contributor

@nadim-az nadim-az commented Sep 4, 2025

No description provided.

@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ironbird Ready Ready Preview Comment Sep 11, 2025 11:59pm

@nadim-az nadim-az marked this pull request as draft September 4, 2025 03:50
@nadim-az nadim-az changed the title chore: run setup commands via script chore: speed up workflow Sep 5, 2025
@nadim-az nadim-az marked this pull request as ready for review September 9, 2025 03:09
1. Rename the `contrib/digitalocean/petri_docker.pkr.hcl.example` file to `contrib/digitalocean/petri_docker.pkr.hcl`
2. Replace `<DO_API_TOKEN>` with your DigitalOcean API token
3. Replace `<GRAF_PYRO_USER>` and `<GRAF_PYRO_PASS>` in `config.alloy` with your Grafana username and password for Pyroscope profiling data publication.
3. Replace `<GRAF_PYRO_USER>`, `<GRAF_PYRO_PASS>`,`<GRAF_LOKI_USER>`, `<GRAF_LOKI_PASS>`,`<GRAF_OTLP_USER>`, `<GRAF_OTLP_PASS>` in `config.alloy` with your Grafana username and password for Pyroscope profiling data publication.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you need grafana admin to create the images yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah thats correct

Comment on lines +270 to +280
amount := ""
for i, coin := range genesisAmounts {
if i != 0 {
amount += ","
}
amount += fmt.Sprintf("%s%s", coin.Amount.String(), coin.Denom)
}

var addGenesisAccountCmd []string
if n.GetChainConfig().UseGenesisSubCommand {
addGenesisAccountCmd = append(addGenesisAccountCmd, "genesis")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same logic as executed above. Why do we need to write this code in multiple places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the validator which collect-gentxs is run on has to have the other accounts in its genesis state otherwise it will fail to recognize the account

Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
@nadim-az nadim-az merged commit 743d3eb into main Sep 11, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants