Skip to content

Fix typos in README.md, swap.rs, contract.rs, and ibc.rs #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ To deploy the Skip Swap contracts, the steps are as follows:
MNEMONIC = "<YOUR MNEMONIC HERE>"
```

7. Generate the entry point contract address using `instatiate2` which generates determinsitic cosmwasm contract addresses. This is necessary to allow the adapter contracts to whitelist the entry point contract before it is instantiated. To do this, you will need the daemon of the respective chain you are deploying on, and running the following command for the chain's CLI (replace osmosisd with network client being used):
7. Generate the entry point contract address using `instatiate2` which generates deterministic cosmwasm contract addresses. This is necessary to allow the adapter contracts to whitelist the entry point contract before it is instantiated. To do this, you will need the daemon of the respective chain you are deploying on, and running the following command for the chain's CLI (replace osmosisd with network client being used):
```
osmosisd query wasm build-address <CHECK SUM HASH OF CONTRACT> <ADDRESS THAT WILL INSTANTIATE> <SALT AS HEX STRING (31 is b'1')>
```
Expand All @@ -173,7 +173,7 @@ To deploy the Skip Swap contracts, the steps are as follows:

9. Update the salt used in the config if needed (default is "1", which is 31 in the chain daemon generator)
``` toml
# SALT USED TO GENERATE A DETERMINSTIC ADDRESS
# SALT USED TO GENERATE A DETERMINISTIC ADDRESS
SALT = "1"
```

Expand All @@ -196,4 +196,4 @@ To deploy the Skip Swap contracts, the steps are as follows:

# About Skip

Skip helps developers provide extraordinary user experiences across all stages of the transaction lifecycle, from transaction construction, through cross-chain relaying + tracking, to block construction.
Skip helps developers provide extraordinary user experiences across all stages of the transaction lifecycle, from transaction construction, through cross-chain relaying + tracking, to block construction.
6 changes: 3 additions & 3 deletions contracts/adapters/swap/duality/src/contract.rs
Original file line number Diff line number Diff line change
Expand Up @@ -449,15 +449,15 @@ fn query_simulate_smart_swap_exact_asset_in_with_metadata(
if routes.len() != 1 {
return Err(ContractError::SmartSwapUnsupported);
}
let responce = query_simulate_swap_exact_asset_in_with_metadata(
let response = query_simulate_swap_exact_asset_in_with_metadata(
deps,
env,
asset_in,
routes[0].operations.clone(),
include_spot_price,
)?;
if *responce.asset_out.denom() == ask_denom {
Ok(responce)
if *response.asset_out.denom() == ask_denom {
Ok(response)
} else {
Err(ContractError::SmartSwapUnexpectedOut)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/skip/src/ibc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ impl TryFrom<IbcFee> for Coins {

impl IbcFee {
// one_coin aims to mimic the behavior of cw_utls::one_coin,
// returing the single coin in the IbcFee struct if it exists,
// returning the single coin in the IbcFee struct if it exists,
// erroring if 0 or more than 1 coins exist.
//
// one_coin is used because the entry_point contract only supports
Expand Down
4 changes: 2 additions & 2 deletions packages/skip/src/swap.rs
Original file line number Diff line number Diff line change
Expand Up @@ -280,15 +280,15 @@ pub struct SwapExactAssetOut {
pub refund_address: Option<String>,
}

// Swap object that swaps the remaining asset recevied
// Swap object that swaps the remaining asset received
// from the contract call minus fee swap (if present)
#[cw_serde]
pub struct SwapExactAssetIn {
pub swap_venue_name: String,
pub operations: Vec<SwapOperation>,
}

// Swap object that swaps the remaining asset recevied
// Swap object that swaps the remaining asset received
// over multiple routes from the contract call minus fee swap (if present)
#[cw_serde]
pub struct SmartSwapExactAssetIn {
Expand Down