Update Axelar handler to support new swap router #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thal0x
changed the title
dhfang
approved these changes
May 29, 2025
Collaborator
dhfang
left a comment
dhfang
left a comment
There was a problem hiding this comment.
Just pointing out that since we are generally changing what calldata our handler expects without changing the interfaces, we will need to deploy an entirely new set of handler contracts when we migrate. Otherwise, if we deploy via contract upgrades instead we can run into edge cases where contracts get upgraded mid transfer and the transfer payload is no longer compatible with the updated contracts.
| error NativePaymentFailed(); | ||
| error WrappingNotEnabled(); | ||
| error SwapFailed(); | ||
| error SwapFailedError(); |
Member
Author
There was a problem hiding this comment.
I don't actually understand why but I randomly started running into compilation errors
AxelarHandler/src/AxelarHandler.sol
Outdated
| import {Initializable} from "lib/openzeppelin-contracts-upgradeable/contracts/proxy/utils/Initializable.sol"; | ||
|
|
||
| import {ISwapRouter02} from "./interfaces/ISwapRouter02.sol"; | ||
| // import {ISwapRouter02} from "./interfaces/ISwapRouter02.sol"; |
[API-4248] Wrap and unwrap ETH
Minor swap router updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the AxelarHandler contract to support the new swap router. Axelar is unique to our other handler contracts because it is the only bridge we support transfer + swaps. The contract included a lot of swap logic that is now moved to the swap router itself.