Skip to content

Minor swap router updates #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thal0x merged 7 commits into from
May 30, 2025
Merged

Minor swap router updates #33

thal0x merged 7 commits into from
May 30, 2025

Conversation

@thal0x
Copy link
Member

@thal0x thal0x commented May 28, 2025 •
edited
Loading

  • Adds contract ownership functionality to the swap router
  • In UniswapV2Data removed zeroToOne in favor of tokenIn and tokenOut, this makes logic in the API a bit more simple
  • Add ExchangeType enum instead of using uint256

@thal0x thal0x self-assigned this May 28, 2025
dhfang
dhfang approved these changes May 29, 2025
View reviewed changes
SwapRouter/broadcast/Deploy.s.sol/42161/run-1747848647.json
@@ -0,0 +1,29 @@
{
Copy link
Collaborator

@dhfang dhfang May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to include this

Copy link
Member Author

@thal0x thal0x May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@thal0x
Merge pull request #34 from skip-mev/jw/weth
ae2aca2 
[API-4248] Wrap and unwrap ETH
@thal0x thal0x merged commit 09b8050 into jw/update-axelar-handler May 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhfang dhfang dhfang approved these changes

Assignees

@thal0x thal0x

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thal0x @dhfang