-
Notifications
You must be signed in to change notification settings - Fork 22
[FRE-1650, FRE-1522] Update History page design and reduce API calls #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
packages/widget/src/state/history.ts:15
- Ensure that merging TransactionHistoryItem with TxsStatus via an intersection type does not introduce unintended property conflicts. It may be beneficial to verify that overlapping field names have compatible types.
} & TxsStatus;
packages/widget/src/hooks/useTxHistory.ts:37
- Returning 'incomplete' might not conform to the expected SimpleStatus values; consider using a valid status or updating the SimpleStatus type definition accordingly.
if (txs.length !== txsRequired) return "incomplete";
Show loading spinner if last tx in list has not settled yet
Show recommendedSymbol for sourceAsset, show symbol on chainName for dest asset
on mobile, only show recommendedSymbol
added < 0.01
