Skip to content

[FRE-1650, FRE-1522] Update History page design and reduce API calls #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

toddkao
Copy link
Collaborator

@toddkao toddkao commented Apr 8, 2025

Show loading spinner if last tx in list has not settled yet

image

Show recommendedSymbol for sourceAsset, show symbol on chainName for dest asset

image

on mobile, only show recommendedSymbol

image

added < 0.01
image

Copy link

changeset-bot bot commented Apr 8, 2025

⚠️ No Changeset found

Latest commit: c7ab193

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 6:26pm

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

packages/widget/src/state/history.ts:15

  • Ensure that merging TransactionHistoryItem with TxsStatus via an intersection type does not introduce unintended property conflicts. It may be beneficial to verify that overlapping field names have compatible types.
} & TxsStatus;

packages/widget/src/hooks/useTxHistory.ts:37

  • Returning 'incomplete' might not conform to the expected SimpleStatus values; consider using a valid status or updating the SimpleStatus type definition accordingly.
if (txs.length !== txsRequired) return "incomplete";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant