[FRE-1641] Improve Bad Price Error Handling #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rice impact warnings more effectively. Update SwapPage to rely solely on API warning type for bad price warnings.
daps94
requested review from
codingki,
NotJeremyLiu,
toddkao and
ericHgorski
as code owners
🦋 Changeset detectedLatest commit: 3d0bb84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
daps94
changed the title
toddkao
reviewed
Apr 14, 2025
packages/widget/src/pages/ErrorPage/ErrorPageBadPriceWarning.tsx
Outdated
Show resolved
Hide resolved
codingki
reviewed
Apr 14, 2025
packages/widget/src/pages/ErrorPage/ErrorPageBadPriceWarning.tsx
Outdated
Show resolved
Hide resolved
codingki
reviewed
Apr 14, 2025
…mization and improve title/description handling. Remove unused priceChangePercentage from SwapPage.
toddkao
reviewed
Apr 14, 2025
packages/widget/src/pages/ErrorPage/ErrorPageBadPriceWarning.tsx
Outdated
Show resolved
Hide resolved
toddkao
reviewed
Apr 14, 2025
Comment on lines
64
to
99
| if (hasUsdValues && swapDifferencePercentage) { | ||
| return { | ||
| title: `Warning: Bad trade (-${swapDifferencePercentage})`, | ||
| descriptionContent: ( | ||
| <> | ||
| You will lose {swapDifferencePercentage} of your input value with this trade | ||
| <br /> | ||
| Input: {sourceDetails?.amount} {sourceDetails?.symbol} ({usdAmountIn}) | ||
| <br /> | ||
| Estimated output: {destinationDetails?.amount} {destinationDetails?.symbol} ({usdAmountOut}) | ||
| </> | ||
| ), | ||
| }; | ||
| } else if (priceImpactPercentage) { | ||
| return { | ||
| title: `Warning: High Price Impact (${priceImpactPercentage})`, | ||
| descriptionContent: ( | ||
| <> | ||
| Executing this trade is expected to impact the price by {priceImpactPercentage}. Please verify the amounts. | ||
| <br /> | ||
|
|
||
| </> | ||
| ), | ||
| }; | ||
| } else { | ||
| return { | ||
| title: "Warning: Bad Trade", | ||
| descriptionContent: ( | ||
| <> | ||
| This trade may result in a poor execution price. Please verify the amounts carefully. | ||
| <br /> | ||
|
|
||
| </> | ||
| ), | ||
| }; | ||
| } |
There was a problem hiding this comment.
nit: this is purely a stylistic thing, but in the cases where each if condition has an early return I prefer this:
if () {
return 1;
}
if () {
return 2;
}
return 3;over
if () {
return 1;
} else if () {
return 2;
} else {
return 3;
}There was a problem hiding this comment.
oh you updated it before I finished writing my comment 😆
toddkao
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance ErrorPageBadPriceWarning component to handle USD values and p…rice impact warnings more effectively. Update SwapPage to rely solely on API warning type for bad price warnings.