[CS-1099] fix: security vulnerabilities in golang packages#69
Open
[CS-1099] fix: security vulnerabilities in golang packages#69
Conversation
Member
Author
|
a lot of prometheus libraries have vanished for some reason. did i do something wrong? or someone else didn't do |
| module github.com/skit-ai/vcore | ||
|
|
||
| go 1.19 | ||
| go 1.21 |
Contributor
|
@greed2411 let's not use JIRA IDs in the commits/MRs here since this is an open-source project and github is not linked to JIRA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing security vulnerabilities:
also have upgraded go.mod file from 1.19 golang to 1.21
im unable to test things, how can we review these fixes are good enough and make a new release? @vipul-sharma20 / @sreeram-narayanan
attaching the trivy vulnerabilities found on the
masterbranch:trivy_before_fix.txt
and trivy didn't find anything on this new
vanta_security_upgradesbranch. thus getting rid of 2 vulnerabilities (high + critical)this is the command used btw:
trivy fs ./ --scanners vuln --severity HIGH,CRITICAL,MEDIUM > trivy_before_fix.txt