fix(fe): prevent course delete modal from opening without selection#3639
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the DataTableDeleteButton component to accept a mouse event in handleDeleteButtonClick and call event.preventDefault() when no rows are selected. The reviewer identified a bug where the delete confirmation modal opens prematurely during asynchronous checks when getCanDelete is provided. They suggested calling event.preventDefault() synchronously when getCanDelete is present to prevent this behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
Description
Changes
event.preventDefault()를 호출하도록 수정했습니다.AlertModal의 trigger 동작으로 인해 삭제 확인 모달이 열리는 문제를 방지했습니다.Tests
Before submitting the PR, please make sure you do the following
fixes #123).Closes TAS-2762