Skip to content

Update sklmessages_vi_VN.properties#711

Open
trucpham04 wants to merge 1 commit into
skmedix:mainfrom
trucpham04:main
Open

Update sklmessages_vi_VN.properties#711
trucpham04 wants to merge 1 commit into
skmedix:mainfrom
trucpham04:main

Conversation

@trucpham04

@trucpham04 trucpham04 commented Nov 1, 2025

Copy link
Copy Markdown

These updates improve the naturalness, accuracy, and consistency of the Vietnamese translation:

  • Normalize capitalization: Switching from Title Case to Sentence case
  • Wording: Improved phrasing (e.g., "Đang Chạy" -> "Đang khởi chạy" (Launching), "Chiều Ngang" -> "Chiều rộng" (Width))
  • Clarity: Clarified warning message content (duplicate process, downgrade) and updated button text
  • Terminology: Standardized the use of "launcher" instead of "trình chạy"
  • Translation: Added missing translations for the dedicated GPU option

Summary by CodeRabbit

Release Notes

  • Localization
    • Significantly expanded Vietnamese language support with numerous new translation strings.
    • Updated existing Vietnamese translations for improved wording, clarity, and consistency throughout the interface.
    • Added comprehensive translations across profile management, modpack features, alert dialogs, login screens, settings options, and crash report sections.

These updates improve the naturalness, accuracy, and consistency of the Vietnamese translation:

- Normalize capitalization: Switching from Title Case to Sentence case
- Wording: Improved phrasing (e.g., "Đang Chạy" -> "Đang khởi chạy" (Launching), "Chiều Ngang" -> "Chiều rộng" (Width))
- Clarity: Clarified warning message content (duplicate process, downgrade) and updated button text
- Terminology: Standardized the use of "launcher" instead of "trình chạy"
- Translation: Added missing translations for the dedicated GPU option
@coderabbitai

coderabbitai Bot commented Nov 1, 2025

Copy link
Copy Markdown

Walkthrough

Vietnamese language translation file updated for a launcher application with expanded translation coverage. Numerous new translation keys added across manager, modpack, alert, login, settings, crash, and about sections. Existing translation values updated with revised wording and formatting. No runtime logic modifications.

Changes

Cohort / File(s) Summary
Vietnamese Translation Properties
assets/launcher/lang/sklmessages_vi_VN.properties
Translation file expanded with 80+ new public keys covering manager UI (headers, buttons, editor options), modpack functionality (search, pagination, details), alert dialogs, login screens, settings options, crash reporting, and about section. Existing key translations updated with revised text and formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • The changes are homogeneous (all translation key-value pairs with no logic alterations)
  • Single file scope limits complexity
  • Review primarily involves spot-checking key naming conventions, format consistency, and sampling translations for quality
  • Potential attention areas:
    • Verify all new keys follow consistent naming patterns (dot-separated hierarchical structure)
    • Confirm no duplicate key definitions exist
    • Sample translations for linguistic accuracy and proper Vietnamese diacritics
    • Ensure placeholder keys and info labels maintain correct format

Poem

🐰 A thousand words in Vietnamese flow,
New keys unlock what users know,
From manager halls to settings bright,
Translations dance in perfect light! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Update sklmessages_vi_VN.properties" is directly and fully related to the changeset. It clearly identifies the specific file being modified (the Vietnamese translation properties file) and accurately summarizes the primary change: updating translations within that file. The title is concise, specific enough for a teammate scanning history to understand the main change, and directly corresponds to the file-level changes and objectives described in the PR. While the word "Update" is somewhat generic, it is not vague to the degree of terms like "misc updates," and the specificity of naming the file provides adequate clarity about what is being changed.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cbd9ed and fa39c7d.

📒 Files selected for processing (1)
  • assets/launcher/lang/sklmessages_vi_VN.properties (1 hunks)
🔇 Additional comments (1)
assets/launcher/lang/sklmessages_vi_VN.properties (1)

1-201: Format and structure look solid.

The properties file follows standard Java conventions with proper UTF-8 encoding for Vietnamese characters, consistent hierarchical key naming, and correct escape sequences (e.g., \n on line 189 for multi-line text). All changes align well with the stated PR objectives: capitalization normalized to sentence case, terminology standardized to use "launcher," and missing translations added (e.g., dedicated GPU options on lines 119–120).

No syntax errors or formatting issues detected. The translation keys are well-organized and follow the existing hierarchical structure.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @trucpham04, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Bản cập nhật này tập trung vào việc nâng cao chất lượng và tính hoàn chỉnh của bản dịch tiếng Việt cho ứng dụng. Các thay đổi bao gồm việc chuẩn hóa cách viết hoa, cải thiện cách diễn đạt, làm rõ các thông báo cảnh báo, chuẩn hóa thuật ngữ và bổ sung các bản dịch còn thiếu, nhằm mang lại trải nghiệm người dùng tốt hơn và nhất quán hơn.

Highlights

  • Chuẩn hóa cách viết hoa: Chuyển đổi nhiều cụm từ từ kiểu viết hoa mỗi chữ cái đầu (Title Case) sang kiểu viết hoa câu (Sentence case) để cải thiện tính tự nhiên của bản dịch.
  • Cải thiện cách diễn đạt: Nhiều cụm từ đã được điều chỉnh để có cách diễn đạt tự nhiên và chính xác hơn trong tiếng Việt, ví dụ: "Đang Chạy" thành "Đang khởi chạy" và "Chiều Ngang" thành "Chiều rộng".
  • Làm rõ thông báo cảnh báo: Nội dung các thông báo cảnh báo về tiến trình trùng lặp và hạ cấp cấu hình đã được làm rõ, cung cấp thông tin chi tiết hơn cho người dùng.
  • Chuẩn hóa thuật ngữ: Thuật ngữ "launcher" đã được chuẩn hóa, thay thế cho "trình chạy" ở nhiều nơi để đảm bảo tính nhất quán.
  • Bổ sung bản dịch: Đã thêm các bản dịch còn thiếu cho tùy chọn GPU rời (dedicated GPU) trong phần cài đặt.
  • Cập nhật danh sách người dịch: Tên người dùng 'trucpham04' đã được thêm vào danh sách những người đóng góp bản dịch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Thank you for your contribution! These changes significantly improve the quality of the Vietnamese translation, making it more natural, accurate, and consistent. The normalization of capitalization, improved wording, and clarification of messages are all great enhancements. I have one minor suggestion to further clarify one of the strings. See the detailed comment below.

manager.editor.option.jvmpath.name=Tệp thực thi Java
manager.editor.option.jvmpath.placeholder=Sử dụng Java đi kèm
manager.editor.option.jvmargs.name=Đối số JVM
manager.editor.option.jvmargs.info=Tùy chọn này bỏ qua đối số -Xmx và sử dụng bộ nhớ tối đa

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current translation Tùy chọn này bỏ qua đối số -Xmx và sử dụng bộ nhớ tối đa could be misleading. The original English string is This option ignores -Xmx arguments, use Maximum Memory instead, which is an instruction for the user: the launcher will ignore any -Xmx argument entered in this field, and the user should use the Maximum Memory (RAM) setting instead.

To convey this meaning more clearly, I suggest a different translation.

manager.editor.option.jvmargs.info=Đối số -Xmx sẽ bị bỏ qua. Thay vào đó, hãy dùng cài đặt "Bộ nhớ tối đa (RAM)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant