Update sklmessages_vi_VN.properties#711
Conversation
These updates improve the naturalness, accuracy, and consistency of the Vietnamese translation: - Normalize capitalization: Switching from Title Case to Sentence case - Wording: Improved phrasing (e.g., "Đang Chạy" -> "Đang khởi chạy" (Launching), "Chiều Ngang" -> "Chiều rộng" (Width)) - Clarity: Clarified warning message content (duplicate process, downgrade) and updated button text - Terminology: Standardized the use of "launcher" instead of "trình chạy" - Translation: Added missing translations for the dedicated GPU option
WalkthroughVietnamese language translation file updated for a launcher application with expanded translation coverage. Numerous new translation keys added across manager, modpack, alert, login, settings, crash, and about sections. Existing translation values updated with revised wording and formatting. No runtime logic modifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @trucpham04, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! Bản cập nhật này tập trung vào việc nâng cao chất lượng và tính hoàn chỉnh của bản dịch tiếng Việt cho ứng dụng. Các thay đổi bao gồm việc chuẩn hóa cách viết hoa, cải thiện cách diễn đạt, làm rõ các thông báo cảnh báo, chuẩn hóa thuật ngữ và bổ sung các bản dịch còn thiếu, nhằm mang lại trải nghiệm người dùng tốt hơn và nhất quán hơn. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
Thank you for your contribution! These changes significantly improve the quality of the Vietnamese translation, making it more natural, accurate, and consistent. The normalization of capitalization, improved wording, and clarification of messages are all great enhancements. I have one minor suggestion to further clarify one of the strings. See the detailed comment below.
| manager.editor.option.jvmpath.name=Tệp thực thi Java | ||
| manager.editor.option.jvmpath.placeholder=Sử dụng Java đi kèm | ||
| manager.editor.option.jvmargs.name=Đối số JVM | ||
| manager.editor.option.jvmargs.info=Tùy chọn này bỏ qua đối số -Xmx và sử dụng bộ nhớ tối đa |
There was a problem hiding this comment.
The current translation Tùy chọn này bỏ qua đối số -Xmx và sử dụng bộ nhớ tối đa could be misleading. The original English string is This option ignores -Xmx arguments, use Maximum Memory instead, which is an instruction for the user: the launcher will ignore any -Xmx argument entered in this field, and the user should use the Maximum Memory (RAM) setting instead.
To convey this meaning more clearly, I suggest a different translation.
manager.editor.option.jvmargs.info=Đối số -Xmx sẽ bị bỏ qua. Thay vào đó, hãy dùng cài đặt "Bộ nhớ tối đa (RAM)".
These updates improve the naturalness, accuracy, and consistency of the Vietnamese translation:
Summary by CodeRabbit
Release Notes