Fix Spanish localization in sklmessages_es_MX.properties#731
Fix Spanish localization in sklmessages_es_MX.properties#731trolly2712 wants to merge 3 commits into
Conversation
Updated Spanish (Mexico) localization strings for clarity and correctness.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughAdded new Spanish (Mexico) localization keys and updated many existing translations in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @trolly2712, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! Esta solicitud de extracción se centra en perfeccionar las cadenas de localización en español (México) dentro del archivo Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
assets/launcher/lang/sklmessages_es_MX.properties (1)
87-121:⚠️ Potential issue | 🟡 MinorAcento en “línea” y eliminar espacios finales.
Pequeños ajustes de localización y formato.
✅ Proposed fix
-login.button.switch.online=Cambiar a modo en linea +login.button.switch.online=Cambiar a modo en línea -settings.option.dgpu.name=Usar GPU Dedicada +settings.option.dgpu.name=Usar GPU Dedicada -manager.header.profiles=Instalaciones +manager.header.profiles=Instalaciones
🤖 Fix all issues with AI agents
In `@assets/launcher/lang/sklmessages_es_MX.properties`:
- Around line 66-70: The localized strings contain a typo and inconsistent
terminology: update crash.alert.button.open from "Abrir pagina web" to "Abrir
página web" (add the accent) and change crash.footer.button.link from "Obtener
link para el reporte" to a standardized Spanish term such as "Obtener enlace
para el reporte" (replace "link" with "enlace"); verify there are no other
occurrences of "link" in this resource file and make them consistent with
"enlace" as well.
- Around line 60-61: Remove the trailing space at the end of the crash.vanilla
message and fix the incorrect "a el/los" phrase in crash.modded by replacing
"envía este reporte a el/los autores del mod" with "envía este reporte a los
autores del mod"; locate the two message keys crash.vanilla and crash.modded and
update their string values accordingly.
- Around line 54-56: Update the Spanish translations to fix missing accents and
make "snapshot" consistent with the feminine "versión": change the value for
versions.version.latestalt from "Última version" to "Última versión", ensure
versions.version.latest-release remains "Último lanzamiento" (masculine is
correct for "lanzamiento"), and change versions.version.latest-snapshot from
"Última Snapshot" to a feminine, consistent form such as "Última snapshot" (or
replace with the Spanish term "Última instantánea") so casing and accents are
correct and genders align.
- Around line 186-187: Update the Spanish message value for
alert.downgrade.label.body to include the missing diacritics: change "version"
to "versión" and "configuracion" to "configuración" so the string reads "¡Parece
que has usado un launcher diferente a este! \nSi quieres utilizar esta versión,
tendremos que reiniciar tu configuración." Leave the key names
(alert.downgrade.label.body and alert.downgrade.button.reset) unchanged.
- Around line 142-163: Replace three Spanish typos in the resource strings:
change the value of manager.editor.option.directory.info.link from "Haz click
aquí" to "Haz clic aquí"; change manager.editor.option.visibility.keep.info from
"Esta opción no es recomendada para PC's de bajos recursos" to "Esta opción no
es recomendable para PCs de bajos recursos" (or keep "Esta opción no es
recomendable para PC de bajos recursos" per preferred style) removing the
apostrophe and using the correct adjective form; and change
manager.editor.option.jvmargs.info from "Esta opción ignora los argumentos -Xmx,
usa la opcion de 'Memoria máxima' en su lugar" to "Esta opción ignora los
argumentos -Xmx; usa la opción de 'Memoria máxima' en su lugar" (add the accent
on "opción" and fix punctuation). Ensure you update only the string values for
the keys manager.editor.option.directory.info.link,
manager.editor.option.visibility.keep.info, and
manager.editor.option.jvmargs.info.
| crash.alert.button.open=Abrir pagina web | ||
| crash.header.title=El juego tuvo un error inesperado | ||
| crash.footer.button.close=Cerrar | ||
| crash.footer.button.view=Ver reporte | ||
| crash.footer.button.link=Obtener link para reportar | ||
| crash.footer.button.link=Obtener link para el reporte |
There was a problem hiding this comment.
Corregir “página” y estandarizar “enlace”.
Ortografía y consistencia terminológica.
✅ Proposed fix
-crash.alert.button.open=Abrir pagina web
-crash.footer.button.link=Obtener link para el reporte
+crash.alert.button.open=Abrir página web
+crash.footer.button.link=Obtener enlace para el reporte🤖 Prompt for AI Agents
In `@assets/launcher/lang/sklmessages_es_MX.properties` around lines 66 - 70, The
localized strings contain a typo and inconsistent terminology: update
crash.alert.button.open from "Abrir pagina web" to "Abrir página web" (add the
accent) and change crash.footer.button.link from "Obtener link para el reporte"
to a standardized Spanish term such as "Obtener enlace para el reporte" (replace
"link" with "enlace"); verify there are no other occurrences of "link" in this
resource file and make them consistent with "enlace" as well.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the Spanish (Mexico) localization by correcting numerous typos, adding missing accents, and refining phrasing for better clarity and correctness. The changes are thoughtful and enhance the user experience. I've identified a few minor issues, mainly related to consistency and small grammatical points, which I've detailed in the review comments. Overall, this is a great contribution to the project.
| sidebar.button.manager=Installations Manager | ||
| sidebar.menu.item.edit=Editar instalacion | ||
| sidebar.menu.item.duplicate=Duplicar instalacion | ||
| sidebar.button.manager=Administrador de instancias |
There was a problem hiding this comment.
The switch to using "instancia" instead of "instalación" is a good choice for this context. However, this terminology is not used consistently throughout the file. Several keys still use "instalación" or "instalaciones".
For example:
sidebar.menu.item.browse(line 27)settings.option.sorting.name(line 102)manager.header.profiles(line 120)manager.editor.header.title(line 133)
To maintain consistency, it would be best to update all related keys to use "instancia"/"instancias".
| crash.modded=Creemos que tu juego probablemente tenga mods, y como tal, no podemos aceptar este reporte de error. Sin embargo, si realmente usas mods, envía este reporte a el/los autores del mod para que lo revisen | ||
| crash.sorry=¡Oh no! Parece que crasheó el juego. Perdónanos por el accidente :( | ||
| crash.vanilla=Usando magia y amor, hemos logrado obtener algunos detalles sobre el crasheo, y vamos a investigar esto lo más pronto que podamos. Puedes ver el reporte completo acá abajo | ||
| crash.modded=Creemos que tu juego probablemente tenga mods, y como tal, no podemos aceptar este reporte de error. Sin embargo, si realmente usas mods, envía este reporte a el/los autores del mod para que lo revisen. |
There was a problem hiding this comment.
There's a small grammatical error here. In Spanish, the preposition "a" followed by the masculine singular article "el" must be contracted to "al". The phrase "a el/los" should be corrected to "al/a los".
crash.modded=Creemos que tu juego probablemente tenga mods, y como tal, no podemos aceptar este reporte de error. Sin embargo, si realmente usas mods, envía este reporte al/a los autores del mod para que lo revisen.
| manager.editor.option.jvmpath.placeholder=Usa entorno de ejecución Java empaquetado | ||
| manager.editor.option.jvmargs.name=Argumentos JVM | ||
| manager.editor.option.jvmargs.info=Esta opcion ignora el argumento -Xmx, usa la opcion de 'Memoria maxima' | ||
| manager.editor.option.jvmargs.info=Esta opción ignora los argumentos -Xmx, usa la opcion de 'Memoria máxima' en su lugar |
There was a problem hiding this comment.
The word "opcion" is missing an accent. It should be written as "opción".
manager.editor.option.jvmargs.info=Esta opción ignora los argumentos -Xmx, usa la opción de 'Memoria máxima' en su lugar
| alert.downgrade.button.cancel=Olvidalo, cierra el launcher | ||
| alert.downgrade.window.title=Advertencia de instancias incompatibles | ||
| alert.downgrade.label.title=¿Reiniciar instalaciones? | ||
| alert.downgrade.label.body=¡Parece que has usado un launcher diferente a este! \nSi quieres utilizar esta version, tendremos que reiniciar tu configuracion. |
There was a problem hiding this comment.
There are a couple of words in this line that are missing their required accents. Specifically, version should be versión and configuracion should be configuración.
alert.downgrade.label.body=¡Parece que has usado un launcher diferente a este! \nSi quieres utilizar esta versión, tendremos que reiniciar tu configuración.
1 participant
Updated Spanish (Mexico) localization strings for clarity and correctness.
Summary by CodeRabbit
New Features
Documentation