Adjust styling of language selection#317
Merged
Merged
Conversation
Adjustments as recommended in #301 (comment) And also made buttons round independent of used letters.
Member
|
Looks better than before (from https://test.skohub.io/acka47/testing-skohub-vocabs/heads/master/w3id.org/kim/hcrt/scheme.html): 
It is strange, though, that the three language tags are not grouped evenly in threes over the two rows. If this could be adjusted easily, please do. Otherwise, +1. |
Member
|
As discussed today, we might as well merge as is as it is already an improvement. @Phu2 , let me know if you make adjustments and I need to do another review. |
Contributor
|
@acka47 I think it's good enough. Please approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjustments as recommended in
#301 (comment)
And also made buttons round independent of used letters.
Deployed to
devfor testing.