__sed: Don't interpret --script - #148
Merged
4nd3r merged 2 commits intoAug 8, 2025
Merged
Conversation
If the script contains dollar signs, these can be interpreted as shell variables
if the here document is not quoted.
e.g. --script '1,/^DEVICESCAN/s#^DEVICESCAN.*$#DEVICESCAN ...#'
results in:
code-remote:stderr
------------------
sed: unmatched '#'
echo can interpret escape sequences which may interfere with the script. It's better to just use or cat the script so that no escape sequences are interpreted where they shouldn't.
4nd3r
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing skonfig/extra#44 I discovered that the
__sedtype contains two bugs which cause it to interpret the script contents in unwanted ways:$in--scriptas parameter expansionsechocan interpret escape sequencesAs another optimisation step I think it should be possible to get rid of the here document altogether, albeit at the price of a less "explicit"
code-remote.Instead of reading the
--scriptparameter contents and pasting them into a here document one could pass the parameter file tosed -fon the target directly (at least in the case where--scriptis not-).