Conversation
…rides target the same property
Two related bugs caused 'the same pseudo selector or at-rule cannot be used more than once'
for components like:
styled.textarea`
border: ${themedBorder('bgBorder')};
border-color: ${(p) => p.$hasError ? p.theme.color.redBase : undefined};
&:focus {
border-color: ${(p) => p.$hasError ? p.theme.color.redBase : p.theme.color.controlPrimary};
}
`;
1. `(p) => p.$x ? value : undefined` (or `null`/`false`/`""`) now resolves to a
single positive variant bucket via `splitVariantsResolved*` instead of falling
through to a dynamic style function, matching the semantics of `p.$x && value`
and avoiding pseudo-map collisions.
2. When seeding `default` of a new pseudo map from an inherited base value, the
inherited value's own `default` is now unwrapped instead of being nested,
preventing malformed shapes like `{ default: { default: A, ":focus": B }, ":focus": C }`.
Co-authored-by: Kenneth Skovhus <skovhus@users.noreply.github.com>
Contributor
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d38a23cd5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… : value` The negative-only branch added in the previous commit emitted a single `splitVariantsResolvedValue` variant with a `!prop` `when` key, but `handleSplitVariantsResolvedValue` treats negated entries as the unconditional default and applies them directly to the base `styleObj`. That silently dropped the `!prop` gate and produced always-on styles. Restrict `buildOneSidedVariantResult` to the positive-only direction (`prop ? value : undefined/null/false/""`) — which was the originally reported pattern — and let the inverse fall through to the dynamic style-function fallback. Add a regression test that fails if the unconditional-leak ever reappears. Addresses Codex review on PR #391. Co-authored-by: Kenneth Skovhus <skovhus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "the same pseudo selector or at-rule cannot be used more than once" when a property has a
prop ? value : undefinedoverride at the base scope and another conditional override under a pseudo selector.(p) => p.$x ? value : undefinednow resolves to a single positive variant bucket (matching&&semantics), and inherited pseudo maps are unwrapped when seedingdefaultso the variant bucket no longer nests them.