feat(adapter): emit sx prop when re-styling sx-aware components#394
Draft
feat(adapter): emit sx prop when re-styling sx-aware components#394
sx prop when re-styling sx-aware components#394Conversation
…ing sx-aware components
Adds an optional adapter hook 'wrappedComponentInterface' that lets the
codemod know an imported component already accepts a StyleX 'sx' prop.
When wrapping such a component via styled(Component) and 'useSxProp' is
enabled, the codemod emits 'sx={styles.x}' instead of
'{...stylex.props(styles.x)}' and forwards className/style unchanged so
the wrapped component handles merging itself.
Co-authored-by: Kenneth Skovhus <skovhus@users.noreply.github.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional adapter hook
wrappedComponentInterfaceso the codemod can emitsx={styles.x}instead of{...stylex.props(styles.x)}whenstyled(Component)wraps an already-migrated component that accepts a StyleXsxprop. RequiresuseSxProp: true.