MAINT - Removing some deprecated features#1567
Merged
Merged
Conversation
rcap107
changed the title
Member
Author
|
Ready for review, to be merged in 0.7.0 |
rcap107
changed the title
jeromedockes
reviewed
Dec 7, 2025
jeromedockes
approved these changes
Dec 9, 2025
|
|
||
| This ensures that tests run in isolation and don't affect each other's | ||
| configuration state, even when running in parallel or in different orders. | ||
| This prevents race conditions where one test's config changes could leak |
Member
There was a problem hiding this comment.
the config is stored in thread local data so I'm not sure 'in parallel' or 'race conditions' are really the issue here, but rather that as you say above we want to make sure each test cleans up after itself does not alter the program's global state, possibly affecting subsequent tests
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
…into pr/rcap107/1567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing part of #1566