DOC - More fixes and improvements to the user guide#1574
Conversation
dholzmueller
left a comment
There was a problem hiding this comment.
Thanks, looks mostly good to me!
|
In the end I decided to revamp most of the user guide, so this is a much bigger PR than I had originally intended |
|
Most of the file changes are actually moving stuff around |
|
Main changes:
I still want to improve the Data Ops getting started example and user guide section. |
|
If you think the overall outline is good, I think so.
I think so indeed.
We can always iterate and fix stuff later
Yes!
|
|
@rcap107 : can you resolve conflicts, in the mean time :) |
|
Start of a review performed in a broken way, when I find 3mn between meetings. Sorry, the review will be unstructured.... First point: isn't the link "[Discover the skrub DataOps →]" on the front page broken? Maybe check links / run sphinx's linkcheck? |
it was broken because the numbering of the examples was changed we really should move the dataops examples to 50+ or something, otherwise every time we change one of the previous examples we need to go and fix all the links |
That's a good idea! Do you want to have a go at it? |
Only after this gets merged |
Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org>
| @@ -0,0 +1,10 @@ | |||
| Column selection inside a pipeline | |||
| ---------------------------------- | |||
There was a problem hiding this comment.
| ---------------------------------- | |
| ---------------------------------- | |
| .. currentmodule:: skrub | |
This is important so that the symbols actually turn into links to the API documentation (very important for the user)
|
General comment: many of the @rcap107 : could you review a bit the generated code to find and fix these issues. They are a quite severe regression |
I'll check all the files tomorrow |
jeromedockes
left a comment
There was a problem hiding this comment.
thanks a lot for all this @rcap107 , I'll continue reading it :)
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
Co-authored-by: Jérôme Dockès <jerome@dockes.org>
GaelVaroquaux
left a comment
There was a problem hiding this comment.
Many small suggestions mostly for formatting reasons.
My main comment is that the sections on DataOps goes too much in details, and people will not read through and thus not discover the features.
It should be made more high level, with mostly text and pointers, and the corresponding pages with a lot of code should be, IMHO, moved to examples.
I will apply all the suggested changes, and merge, unless I've broken something.
|
|
||
| In this section we cover all about the skrub Data Ops, from starting out with a | ||
| simple example, to more advanced concepts like parameter tuning and and pipeline | ||
| validation. |
There was a problem hiding this comment.
The below does not render great in the site's table of contents (because the titles on this page are not exposed on the site's table of content) but I don't know how to fix this, so I'm moving on for now.
| @@ -0,0 +1,94 @@ | |||
| .. currentmodule:: skrub | |||
|
|
|||
There was a problem hiding this comment.
That's a lot of code for a documentation page. I typically prefer moving these to an example, I find it easier to maintain.
There was a problem hiding this comment.
The same comment applies to many of the pages in this section.
We could make a separate, dedicated gallery, that is inserted here, if useful
Co-authored-by: Jérôme Dockès <jerome@dockes.org> Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org>
Co-authored-by: Jérôme Dockès <jerome@dockes.org> Co-authored-by: Gael Varoquaux <gael.varoquaux@normalesup.org>
This PR is fixing a number of issues in the user guide and in some other parts of the documentation, and it reworks the overall structure of the user guide to make it easier for users to parse.
The main objective was to make it easier for readers to find what they are looking for by searching the left sidebar in the user guide. The current (as time of edit) user guide has a lot of content hidden behind titles that do not really describe the content of their section.
This PR addresses the problem by moving the content of the user guide from long files to a new
modules/folder, which contains a subfolder for each "chapter" of the user guide. Subfolders contain the old subsections.The result is that now the sidebar shows the title of these subsections, making it easier for users to find information about the library.
The content of the guide has remained mostly the same: I reused most of what was already there, sometimes integrating the text with examples, or moving things around for clarity.
Additional changes include:
skrub) throughout the docs