DOC - adding a guide on how to write examples #1578
Merged
Merged
Conversation
jovan-stojanovic
left a comment
jovan-stojanovic
left a comment
Member
There was a problem hiding this comment.
Super cool PR.
A general comment:
in the "Development" section of the website, there are subsections including the one you want to add and "Contributing to skrub". "Contributing to skrub" is then also a section in the drop-down of "More". We might want to add an issue to clear this up.
jovan-stojanovic
approved these changes
Sep 22, 2025
rcap107
added a commit
to rcap107/skrub
that referenced
this pull request
Sep 25, 2025
rcap107
added a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.