MAINT - adding explicit linkcheck command#1615
Merged
Merged
Conversation
rcap107
changed the title
jeromedockes
approved these changes
Sep 19, 2025
jeromedockes
left a comment
jeromedockes
left a comment
Member
There was a problem hiding this comment.
super useful, thanks!
there seem to be a couple of broken links indeed :/
should this be mentioned in the developer docs to help people know it's there?
Member
Author
I'll add a note on that and merge |
rcap107
added a commit
to rcap107/skrub
that referenced
this pull request
Sep 25, 2025
rcap107
added a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linkcheck function is useful for testing links that may be broken, but calling make linkcheck runs all the examples which takes forever for no good reason, so I added a noplot version to both the makefile and pyproject